From 83e0ab3adf2732954e6069ca94ab1ba3147c1e67 Mon Sep 17 00:00:00 2001
From: Timofei Larkin <lllamnyp@gmail.com>
Date: Mon, 14 Jul 2025 15:15:24 +0300
Subject: [PATCH] [platform] Autoscale the autoscaler

The Vertical Pod Autoscaler is a component with resource requirements
highly dependent on the environment it is running in, hence it also
needs to be autoscaled to reduce the number of configuration parameters
that platform admins need to manage. This patch introduces an ancillary
autoscaler that watches only the primary autoscaler's namespace and
adjusts its resource requests and limits, since the autoscaler cannot
autoscale itself. In turn, the primary autoscaler can autoscale the
ancillary autoscaler.

[platform] Implement autoscaling for the Vertical Pod Autoscaler itself.

Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
---
 .../templates/vpa-for-vpa.yaml                | 86 +++++++++++++++++++
 .../vertical-pod-autoscaler/values.yaml       |  8 +-
 2 files changed, 88 insertions(+), 6 deletions(-)
 create mode 100644 packages/system/vertical-pod-autoscaler/templates/vpa-for-vpa.yaml

diff --git a/packages/system/vertical-pod-autoscaler/templates/vpa-for-vpa.yaml b/packages/system/vertical-pod-autoscaler/templates/vpa-for-vpa.yaml
new file mode 100644
index 00000000..5fb35fca
--- /dev/null
+++ b/packages/system/vertical-pod-autoscaler/templates/vpa-for-vpa.yaml
@@ -0,0 +1,86 @@
+{{- if .Values.vpaForVPA }}
+---
+apiVersion: v1
+kind: Namespace
+metadata:
+  labels:
+    cozystack.io/system: "true"
+  name: cozy-vpa-for-vpa
+---
+apiVersion: helm.toolkit.fluxcd.io/v2
+kind: HelmRelease
+metadata:
+  labels:
+    cozystack.io/repository: system
+    cozystack.io/system-app: "true"
+  name: vpa-for-vpa
+  namespace: cozy-vpa-for-vpa
+spec:
+  chart:
+    spec:
+      chart: cozy-vertical-pod-autoscaler
+      reconcileStrategy: Revision
+      sourceRef:
+        kind: HelmRepository
+        name: cozystack-system
+        namespace: cozy-system
+      version: '>= 0.0.0-0'
+  dependsOn:
+  - name: monitoring-agents
+    namespace: cozy-monitoring
+  install:
+    crds: Skip
+    remediation:
+      retries: -1
+  interval: 5m
+  releaseName: vertical-pod-autoscaler
+  upgrade:
+    crds: Skip
+    remediation:
+      retries: -1
+  values:
+    vpaForVPA: false
+    vertical-pod-autoscaler:
+      nameOverride: vpa-for-vpa
+      fullnameOverride: vpa-for-vpa
+      admissionController:
+        enabled: false
+      recommender:
+        extraArgs:
+          vpa-object-namespace: {{ .Release.Namespace }}
+          recommender-name: vpa-for-vpa
+        resources:
+          limits:
+            memory: 512Mi
+          requests:
+            cpu: 100m
+            memory: 512Mi
+---
+apiVersion: autoscaling.k8s.io/v1
+kind: VerticalPodAutoscaler
+metadata:
+  name: vpa-for-vpa
+  namespace: {{ .Release.Namespace }}
+spec:
+  recommenders:
+  - name: vpa-for-vpa
+  targetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: {{ dig "vertical-pod-autoscaler" "nameOverride" "" .Values.AsMap | default "vertical-pod-autoscaler" | trunc 63 | trimSuffix "-" }}-recommender
+  updatePolicy:
+    updateMode: Auto
+---
+apiVersion: autoscaling.k8s.io/v1
+kind: VerticalPodAutoscaler
+metadata:
+  name: vpa-for-vpa
+  namespace: cozy-vpa-for-vpa
+spec:
+  targetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: vpa-for-vpa-recommender
+  updatePolicy:
+    updateMode: Auto
+{{- end }}
diff --git a/packages/system/vertical-pod-autoscaler/values.yaml b/packages/system/vertical-pod-autoscaler/values.yaml
index df4a5d10..751df1a4 100644
--- a/packages/system/vertical-pod-autoscaler/values.yaml
+++ b/packages/system/vertical-pod-autoscaler/values.yaml
@@ -1,3 +1,5 @@
+vpaForVPA: true
+
 vertical-pod-autoscaler:
   crds:
     enabled: false
@@ -23,12 +25,6 @@ vertical-pod-autoscaler:
       pod-namespace-label: namespace
       prometheus-address: http://vmselect-shortterm.tenant-root.svc.cozy.local:8481/select/0/prometheus/
       prometheus-cadvisor-job-name: cadvisor
-    resources:
-      limits:
-        memory: 160Mi
-      requests:
-        cpu: 100m
-        memory: 160Mi
 
   admissionController:
     resources: