mirror of
https://github.com/outbackdingo/cozystack.git
synced 2026-01-27 10:18:39 +00:00
354507a4ea
Some HelmReleases use `chartRef` instead of `chart`. If the lineage webhook finds such a HelmRelease, a nil pointer dereference happens. This patch adds a nil check to guard against this. ```release-note [lineage] Add a nil check to guard against HelmReleases with a nil .spec.chart field when traversing the ownership tree. ``` Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
51 lines
1.4 KiB
Go
51 lines
1.4 KiB
Go
package lineagecontrollerwebhook
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
cozyv1alpha1 "github.com/cozystack/cozystack/api/v1alpha1"
|
|
helmv2 "github.com/fluxcd/helm-controller/api/v2"
|
|
)
|
|
|
|
type chartRef struct {
|
|
repo string
|
|
chart string
|
|
}
|
|
|
|
type appRef struct {
|
|
group string
|
|
kind string
|
|
}
|
|
|
|
type runtimeConfig struct {
|
|
chartAppMap map[chartRef]*cozyv1alpha1.CozystackResourceDefinition
|
|
appCRDMap map[appRef]*cozyv1alpha1.CozystackResourceDefinition
|
|
}
|
|
|
|
func (l *LineageControllerWebhook) initConfig() {
|
|
l.initOnce.Do(func() {
|
|
if l.config.Load() == nil {
|
|
l.config.Store(&runtimeConfig{
|
|
chartAppMap: make(map[chartRef]*cozyv1alpha1.CozystackResourceDefinition),
|
|
appCRDMap: make(map[appRef]*cozyv1alpha1.CozystackResourceDefinition),
|
|
})
|
|
}
|
|
})
|
|
}
|
|
|
|
func (l *LineageControllerWebhook) Map(hr *helmv2.HelmRelease) (string, string, string, error) {
|
|
cfg, ok := l.config.Load().(*runtimeConfig)
|
|
if !ok {
|
|
return "", "", "", fmt.Errorf("failed to load chart-app mapping from config")
|
|
}
|
|
if hr.Spec.Chart == nil {
|
|
return "", "", "", fmt.Errorf("cannot map helm release %s/%s to dynamic app", hr.Namespace, hr.Name)
|
|
}
|
|
s := hr.Spec.Chart.Spec
|
|
val, ok := cfg.chartAppMap[chartRef{s.SourceRef.Name, s.Chart}]
|
|
if !ok {
|
|
return "", "", "", fmt.Errorf("cannot map helm release %s/%s to dynamic app", hr.Namespace, hr.Name)
|
|
}
|
|
return "apps.cozystack.io/v1alpha1", val.Spec.Application.Kind, val.Spec.Release.Prefix, nil
|
|
}
|