From 08857d602bd1cccd642964ccf8394ac38b9f31c7 Mon Sep 17 00:00:00 2001
From: Thomas Eizinger <thomas@eizinger.io>
Date: Wed, 22 Oct 2025 13:07:00 +1100
Subject: [PATCH] chore(client-ffi): add dummy constructor (#10659)

When working on the `client-ffi` module on a Linux or Windows machine,
we currently see a lot of "unused code" warnings. We could feature-gate
the remaining functions too but that would result in not having
code-completion on those platforms at all.

To make working on this module more ergonomic, we add a dummy
constructor for the session.
---
 rust/client-ffi/src/lib.rs | 44 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/rust/client-ffi/src/lib.rs b/rust/client-ffi/src/lib.rs
index 74b8421d6..07eee9217 100644
--- a/rust/client-ffi/src/lib.rs
+++ b/rust/client-ffi/src/lib.rs
@@ -233,6 +233,50 @@ impl Session {
     }
 }
 
+#[uniffi::export]
+impl Session {
+    #[uniffi::constructor]
+    #[expect(
+        clippy::too_many_arguments,
+        reason = "This is the API we want to expose over FFI."
+    )]
+    /// Dummy constructor that isn't feature-gated by an OS.
+    ///
+    /// This only exists to make working on the FFI module from Linux/Windows more convenient without many "unused code" warnings.
+    pub fn new_dummy(
+        api_url: String,
+        token: String,
+        device_id: String,
+        account_slug: String,
+        device_name: Option<String>,
+        os_version: Option<String>,
+        log_dir: String,
+        log_filter: String,
+        device_info: DeviceInfo,
+        is_internet_resource_active: bool,
+    ) -> Result<Self, ConnlibError> {
+        let tcp_socket_factory = Arc::new(socket_factory::tcp);
+        let udp_socket_factory = Arc::new(socket_factory::udp);
+
+        let session = connect(
+            api_url,
+            token,
+            device_id,
+            account_slug,
+            device_name,
+            os_version,
+            log_dir,
+            log_filter,
+            device_info,
+            is_internet_resource_active,
+            tcp_socket_factory,
+            udp_socket_factory,
+        )?;
+
+        Ok(session)
+    }
+}
+
 /// Set up TUN device with retry logic.
 ///
 /// Retries a few times with a small delay, as the NetworkExtension