From 2f9d4d8487295b1d90db895a3e045436bb26af8f Mon Sep 17 00:00:00 2001 From: Jamil Date: Mon, 11 Dec 2023 13:00:11 -0800 Subject: [PATCH] Fix visibility for dark screens (#2849) ![IMG_904438F58D46-1](https://github.com/firezone/firezone/assets/167144/adaeb80e-df24-4278-88ff-5db63665f277) --- .../LogoText.imageset/Contents.json | 64 ++++++++++++++++++- .../{logo-text.svg => logo-text-any.svg} | 0 .../LogoText.imageset/logo-text-dark.svg | 13 ++++ .../LogoText.imageset/logo-text-light.svg | 13 ++++ .../FirezoneKit/Features/AuthView.swift | 1 + 5 files changed, 90 insertions(+), 1 deletion(-) rename swift/apple/Firezone/Assets.xcassets/LogoText.imageset/{logo-text.svg => logo-text-any.svg} (100%) create mode 100644 swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-dark.svg create mode 100644 swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-light.svg diff --git a/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/Contents.json b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/Contents.json index da9272175..f345d5639 100644 --- a/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/Contents.json +++ b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/Contents.json @@ -1,7 +1,29 @@ { "images" : [ { - "filename" : "logo-text.svg", + "filename" : "logo-text-any.svg", + "idiom" : "universal", + "scale" : "1x" + }, + { + "appearances" : [ + { + "appearance" : "luminosity", + "value" : "light" + } + ], + "filename" : "logo-text-light.svg", + "idiom" : "universal", + "scale" : "1x" + }, + { + "appearances" : [ + { + "appearance" : "luminosity", + "value" : "dark" + } + ], + "filename" : "logo-text-dark.svg", "idiom" : "universal", "scale" : "1x" }, @@ -10,6 +32,46 @@ "scale" : "2x" }, { + "appearances" : [ + { + "appearance" : "luminosity", + "value" : "light" + } + ], + "idiom" : "universal", + "scale" : "2x" + }, + { + "appearances" : [ + { + "appearance" : "luminosity", + "value" : "dark" + } + ], + "idiom" : "universal", + "scale" : "2x" + }, + { + "idiom" : "universal", + "scale" : "3x" + }, + { + "appearances" : [ + { + "appearance" : "luminosity", + "value" : "light" + } + ], + "idiom" : "universal", + "scale" : "3x" + }, + { + "appearances" : [ + { + "appearance" : "luminosity", + "value" : "dark" + } + ], "idiom" : "universal", "scale" : "3x" } diff --git a/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text.svg b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-any.svg similarity index 100% rename from swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text.svg rename to swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-any.svg diff --git a/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-dark.svg b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-dark.svg new file mode 100644 index 000000000..1fb26214b --- /dev/null +++ b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-dark.svg @@ -0,0 +1,13 @@ + + + + + + + + + + + + + diff --git a/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-light.svg b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-light.svg new file mode 100644 index 000000000..d4712a051 --- /dev/null +++ b/swift/apple/Firezone/Assets.xcassets/LogoText.imageset/logo-text-light.svg @@ -0,0 +1,13 @@ + + + + + + + + + + + + + diff --git a/swift/apple/FirezoneKit/Sources/FirezoneKit/Features/AuthView.swift b/swift/apple/FirezoneKit/Sources/FirezoneKit/Features/AuthView.swift index 652e6742e..7690d483f 100644 --- a/swift/apple/FirezoneKit/Sources/FirezoneKit/Features/AuthView.swift +++ b/swift/apple/FirezoneKit/Sources/FirezoneKit/Features/AuthView.swift @@ -34,6 +34,7 @@ struct AuthView: View { VStack( alignment: .center, content: { + Spacer() Image("LogoText") Spacer() Button("Sign in") {