From 311988c5a28c44fbabea0cf142db7c731f830aad Mon Sep 17 00:00:00 2001 From: Jamil Date: Sun, 16 Feb 2025 12:57:03 -0800 Subject: [PATCH] fix(portal): Only compute diff for metrics with both start and end times (#8147) A fix for a nil error from #8146 --- .../lib/domain/telemetry/reporter/google_cloud_metrics.ex | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/elixir/apps/domain/lib/domain/telemetry/reporter/google_cloud_metrics.ex b/elixir/apps/domain/lib/domain/telemetry/reporter/google_cloud_metrics.ex index 342899651..55b5ff71e 100644 --- a/elixir/apps/domain/lib/domain/telemetry/reporter/google_cloud_metrics.ex +++ b/elixir/apps/domain/lib/domain/telemetry/reporter/google_cloud_metrics.ex @@ -144,15 +144,14 @@ defmodule Domain.Telemetry.Reporter.GoogleCloudMetrics do defp all_intervals_greater_than_5s?(buffer) do Enum.all?(buffer, fn {{schema, _name, _tags, _unit}, measurements} -> {started_at, ended_at, _} = measurements - diff = DateTime.diff(ended_at, started_at, :second) # Only Distribution and Summary metrics use intervals case schema do Metrics.Counter -> true Metrics.Sum -> true Metrics.LastValue -> true - Metrics.Distribution -> diff > 5 - Metrics.Summary -> diff > 5 + Metrics.Distribution -> DateTime.diff(ended_at, started_at, :second) > 5 + Metrics.Summary -> DateTime.diff(ended_at, started_at, :second) > 5 end end) end