From 383a67ef094d8028f01b7ecd443c409b7adfb243 Mon Sep 17 00:00:00 2001
From: Jamil <jamilbk@users.noreply.github.com>
Date: Wed, 5 Mar 2025 02:34:32 +0000
Subject: [PATCH] fix(portal): Use `href` when navigating out of liveview
 (#8363)

Not a major issue, but LiveView emits a warning for these that cause
monitoring noise.
---
 .../web/lib/web/components/form_components.ex | 20 +++++++++++++++++--
 .../google_workspace/show.ex                  |  2 +-
 .../identity_providers/jumpcloud/show.ex      |  2 +-
 .../microsoft_entra/show.ex                   |  4 +---
 .../settings/identity_providers/okta/show.ex  |  2 +-
 .../identity_providers/openid_connect/show.ex |  4 +---
 6 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/elixir/apps/web/lib/web/components/form_components.ex b/elixir/apps/web/lib/web/components/form_components.ex
index 27bf07047..f9794cf57 100644
--- a/elixir/apps/web/lib/web/components/form_components.ex
+++ b/elixir/apps/web/lib/web/components/form_components.ex
@@ -475,7 +475,7 @@ defmodule Web.FormComponents do
   @doc """
   Base button type to be used directly or by the specialized button types above. e.g. edit_button, delete_button, etc.
 
-  If a navigate path is provided, an <a> tag will be used, otherwise a <button> tag will be used.
+  If a navigate, href, or patch path is provided, an <a> tag will be used, otherwise a <button> tag will be used.
 
   ## Examples
 
@@ -493,6 +493,13 @@ defmodule Web.FormComponents do
     otherwise a <button> tag will be used
     """
 
+  attr :href, :string,
+    required: false,
+    doc: """
+    The path to redirect to using a full page reload, when set an <a> tag will be used,
+    otherwise a <button> tag will be used
+    """
+
   attr :class, :string, default: "", doc: "Custom classes to be added to the button"
   attr :style, :string, default: nil, doc: "The style of the button"
   attr :type, :string, default: nil, doc: "The button type"
@@ -503,9 +510,18 @@ defmodule Web.FormComponents do
     required: false,
     doc: "The icon to be displayed on the button"
 
-  attr :rest, :global, include: ~w(disabled form name value navigate)
+  attr :rest, :global, include: ~w(disabled form name value navigate href)
   slot :inner_block, required: true, doc: "The label for the button"
 
+  def button(%{href: _} = assigns) do
+    ~H"""
+    <.link class={button_style(@style) ++ button_size(@size) ++ [@class]} href={@href} {@rest}>
+      <.icon :if={@icon} name={@icon} class="h-3.5 w-3.5 mr-2" />
+      {render_slot(@inner_block)}
+    </.link>
+    """
+  end
+
   def button(%{navigate: _} = assigns) do
     ~H"""
     <.link class={button_style(@style) ++ button_size(@size) ++ [@class]} navigate={@navigate} {@rest}>
diff --git a/elixir/apps/web/lib/web/live/settings/identity_providers/google_workspace/show.ex b/elixir/apps/web/lib/web/live/settings/identity_providers/google_workspace/show.ex
index 0bf416719..4510b8f23 100644
--- a/elixir/apps/web/lib/web/live/settings/identity_providers/google_workspace/show.ex
+++ b/elixir/apps/web/lib/web/live/settings/identity_providers/google_workspace/show.ex
@@ -100,7 +100,7 @@ defmodule Web.Settings.IdentityProviders.GoogleWorkspace.Show do
       <:action :if={is_nil(@provider.deleted_at)}>
         <.button
           style="primary"
-          navigate={
+          href={
             ~p"/#{@account.id}/settings/identity_providers/google_workspace/#{@provider}/redirect"
           }
           icon="hero-arrow-path"
diff --git a/elixir/apps/web/lib/web/live/settings/identity_providers/jumpcloud/show.ex b/elixir/apps/web/lib/web/live/settings/identity_providers/jumpcloud/show.ex
index b2ba2c182..e5947f32e 100644
--- a/elixir/apps/web/lib/web/live/settings/identity_providers/jumpcloud/show.ex
+++ b/elixir/apps/web/lib/web/live/settings/identity_providers/jumpcloud/show.ex
@@ -102,7 +102,7 @@ defmodule Web.Settings.IdentityProviders.JumpCloud.Show do
       <:action :if={is_nil(@provider.deleted_at)}>
         <.button
           style="primary"
-          navigate={~p"/#{@account.id}/settings/identity_providers/jumpcloud/#{@provider}/redirect"}
+          href={~p"/#{@account.id}/settings/identity_providers/jumpcloud/#{@provider}/redirect"}
           icon="hero-arrow-path"
         >
           Reconnect
diff --git a/elixir/apps/web/lib/web/live/settings/identity_providers/microsoft_entra/show.ex b/elixir/apps/web/lib/web/live/settings/identity_providers/microsoft_entra/show.ex
index 3283603a8..7b91379bd 100644
--- a/elixir/apps/web/lib/web/live/settings/identity_providers/microsoft_entra/show.ex
+++ b/elixir/apps/web/lib/web/live/settings/identity_providers/microsoft_entra/show.ex
@@ -100,9 +100,7 @@ defmodule Web.Settings.IdentityProviders.MicrosoftEntra.Show do
       <:action :if={is_nil(@provider.deleted_at)}>
         <.button
           style="primary"
-          navigate={
-            ~p"/#{@account.id}/settings/identity_providers/microsoft_entra/#{@provider}/redirect"
-          }
+          href={~p"/#{@account.id}/settings/identity_providers/microsoft_entra/#{@provider}/redirect"}
           icon="hero-arrow-path"
         >
           Reconnect
diff --git a/elixir/apps/web/lib/web/live/settings/identity_providers/okta/show.ex b/elixir/apps/web/lib/web/live/settings/identity_providers/okta/show.ex
index 06a419e7a..4a5604f09 100644
--- a/elixir/apps/web/lib/web/live/settings/identity_providers/okta/show.ex
+++ b/elixir/apps/web/lib/web/live/settings/identity_providers/okta/show.ex
@@ -100,7 +100,7 @@ defmodule Web.Settings.IdentityProviders.Okta.Show do
       <:action :if={is_nil(@provider.deleted_at)}>
         <.button
           style="primary"
-          navigate={~p"/#{@account.id}/settings/identity_providers/okta/#{@provider}/redirect"}
+          href={~p"/#{@account.id}/settings/identity_providers/okta/#{@provider}/redirect"}
           icon="hero-arrow-path"
         >
           Reconnect
diff --git a/elixir/apps/web/lib/web/live/settings/identity_providers/openid_connect/show.ex b/elixir/apps/web/lib/web/live/settings/identity_providers/openid_connect/show.ex
index 9866bb39c..7aebbcf54 100644
--- a/elixir/apps/web/lib/web/live/settings/identity_providers/openid_connect/show.ex
+++ b/elixir/apps/web/lib/web/live/settings/identity_providers/openid_connect/show.ex
@@ -93,9 +93,7 @@ defmodule Web.Settings.IdentityProviders.OpenIDConnect.Show do
       <:action :if={is_nil(@provider.deleted_at)}>
         <.button
           style="primary"
-          navigate={
-            ~p"/#{@account.id}/settings/identity_providers/openid_connect/#{@provider}/redirect"
-          }
+          href={~p"/#{@account.id}/settings/identity_providers/openid_connect/#{@provider}/redirect"}
           icon="hero-arrow-path"
         >
           Reconnect