feat(ci): Test that relay restarts don't break existing connected entities (#3671)

~~Highlights the issue hypothesized in #3666~~

This tests that restarting a Relay won't cause sustained downtime.

Sleeps have been removed as they shouldn't necessary -- removing them
will better catch race conditions.

scripts/tests/direct-curl-portal-down.sh

@@ -4,10 +4,8 @@ set -euo pipefail
 
 source "./scripts/tests/lib.sh"
 
-client_curl_resource
+client_curl_resource # Establish a connection
 
 docker compose stop api relay # Stop portal & relay
 
-sleep 5 # Wait for client to disconnect
-
 client_curl_resource

scripts/tests/direct-curl-portal-relay-down.sh

@@ -4,10 +4,8 @@ set -euo pipefail
 
 source "./scripts/tests/lib.sh"
 
-client_curl_resource
+client_curl_resource # Establish a connection
 
 docker compose stop api # Stop portal
 
-sleep 5 # Wait for client to disconnect
-
 client_curl_resource

scripts/tests/direct-curl-portal-restart.sh

@@ -4,10 +4,10 @@ set -euo pipefail
 
 source "./scripts/tests/lib.sh"
 
-client_curl_resource
-
 docker compose restart api # Restart portal
 
-sleep 5 # Wait for client to reconnect
+client_curl_resource
+
+docker compose restart api # Restart again
 
 client_curl_resource

scripts/tests/relayed-curl-portal-down.sh

@@ -7,10 +7,8 @@ source "./scripts/tests/lib.sh"
 install_iptables_drop_rules
 trap remove_iptables_drop_rules EXIT # Cleanup after us
 
-client_curl_resource
+client_curl_resource # Establish a connection
 
 docker compose stop api # Stop portal
 
-sleep 5 # Wait for client to disconnect
-
 client_curl_resource

scripts/tests/relayed-curl-portal-restart.sh

@@ -7,10 +7,10 @@ source "./scripts/tests/lib.sh"
 install_iptables_drop_rules
 trap remove_iptables_drop_rules EXIT # Cleanup after us
 
-client_curl_resource
-
 docker compose restart api # Restart portal
 
-sleep 5 # Wait for client to reconnect
+client_curl_resource
+
+docker compose restart api # Restart again
 
 client_curl_resource

scripts/tests/relayed-curl-relay-restart.sh

@@ -0,0 +1,14 @@
+#!/usr/bin/env bash
+
+set -e
+
+source "./scripts/tests/lib.sh"
+
+install_iptables_drop_rules
+trap remove_iptables_drop_rules EXIT # Cleanup after us
+
+client_curl_resource
+
+docker compose restart relay # Restart relay
+
+client_curl_resource