From 73625e4669adee8df8481caaf9be51ff80094202 Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Fri, 13 Dec 2024 16:37:15 +1100 Subject: [PATCH] chore(relay): don't log all AUTH errors on WARN (#7506) Not all authentication errors are warnings that we need to be alerted about. --- rust/relay/src/server.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/rust/relay/src/server.rs b/rust/relay/src/server.rs index 04f7eeb63..80708499b 100644 --- a/rust/relay/src/server.rs +++ b/rust/relay/src/server.rs @@ -850,7 +850,15 @@ where .verify(&self.auth_secret, username.name(), SystemTime::now()) // This is impure but we don't need to control this in our tests. .map_err(|e| { let (error_response, msg) = make_error_response(Unauthorized, request); - tracing::warn!(target: "relay", "{msg}: MessageIntegrity check failed: {e}"); + + match e { + auth::Error::UnknownNonce | auth::Error::NonceUsedUp | auth::Error::Expired | auth::Error::InvalidPassword => { + tracing::debug!(target: "relay", "{msg}: MessageIntegrity check failed: {e}"); + }, + auth::Error::CannotAuthenticate(_) | auth::Error::InvalidUsername => { + tracing::warn!(target: "relay", "{msg}: MessageIntegrity check failed: {e}") + }, + } error_response })?;