From 7c6eac6af510dd1eb88e2cf77c5cc3a6e83030b5 Mon Sep 17 00:00:00 2001
From: Andrew <a@firezone.dev>
Date: Wed, 28 Aug 2024 10:44:13 -0600
Subject: [PATCH] Hotfix: crash while rendering internet resources for gateways

---
 .../api/lib/api/gateway/views/resource.ex     |  7 +++
 .../api/test/api/gateway/channel_test.exs     | 49 +++++++++++++++++++
 2 files changed, 56 insertions(+)

diff --git a/elixir/apps/api/lib/api/gateway/views/resource.ex b/elixir/apps/api/lib/api/gateway/views/resource.ex
index e0746bfc2..c543447dc 100644
--- a/elixir/apps/api/lib/api/gateway/views/resource.ex
+++ b/elixir/apps/api/lib/api/gateway/views/resource.ex
@@ -1,6 +1,13 @@
 defmodule API.Gateway.Views.Resource do
   alias Domain.Resources
 
+  def render(%Resources.Resource{type: :internet} = resource) do
+    %{
+      id: resource.id,
+      type: :internet
+    }
+  end
+
   def render(%Resources.Resource{type: :dns} = resource) do
     %{
       id: resource.id,
diff --git a/elixir/apps/api/test/api/gateway/channel_test.exs b/elixir/apps/api/test/api/gateway/channel_test.exs
index 8fe500526..8af115428 100644
--- a/elixir/apps/api/test/api/gateway/channel_test.exs
+++ b/elixir/apps/api/test/api/gateway/channel_test.exs
@@ -127,6 +127,55 @@ defmodule API.Gateway.ChannelTest do
       assert DateTime.from_unix!(payload.expires_at) == DateTime.truncate(expires_at, :second)
     end
 
+    test "pushes allow_access message for internet resource", %{
+      account: account,
+      client: client,
+      relay: relay,
+      socket: socket
+    } do
+      resource =
+        Fixtures.Resources.create_resource(
+          type: :internet,
+          account: account
+        )
+
+      channel_pid = self()
+      socket_ref = make_ref()
+      expires_at = DateTime.utc_now() |> DateTime.add(30, :second)
+      otel_ctx = {OpenTelemetry.Ctx.new(), OpenTelemetry.Tracer.start_span("connect")}
+      flow_id = Ecto.UUID.generate()
+      client_payload = "RTC_SD_or_DNS_Q"
+
+      stamp_secret = Ecto.UUID.generate()
+      :ok = Domain.Relays.connect_relay(relay, stamp_secret)
+
+      send(
+        socket.channel_pid,
+        {:allow_access, {channel_pid, socket_ref},
+         %{
+           client_id: client.id,
+           resource_id: resource.id,
+           flow_id: flow_id,
+           authorization_expires_at: expires_at,
+           client_payload: client_payload
+         }, otel_ctx}
+      )
+
+      assert_push "allow_access", payload
+
+      assert payload.resource == %{
+               id: resource.id,
+               type: :internet
+             }
+
+      assert payload.ref
+      assert payload.flow_id == flow_id
+      assert payload.client_id == client.id
+      assert payload.client_ipv4 == client.ipv4
+      assert payload.client_ipv6 == client.ipv6
+      assert DateTime.from_unix!(payload.expires_at) == DateTime.truncate(expires_at, :second)
+    end
+
     test "subscribes for flow expiration event", %{
       account: account,
       client: client,