From 81ba49e2bf536fe1dc5ee55ac5ea4350feef8ae5 Mon Sep 17 00:00:00 2001
From: Thomas Eizinger <thomas@eizinger.io>
Date: Mon, 5 May 2025 22:29:57 +1000
Subject: [PATCH] ci(rust): reorder static analysis (#9025)

Running `clippy` first is more useful because it provides better
feedback around compile-errors. When working with cross-platform code,
it is often the case that one needs to push to CI to ensure everything
builds. Therefore, getting fast feedback is important.
---
 .github/workflows/_rust.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/_rust.yml b/.github/workflows/_rust.yml
index c7558f0e6..7320d01ba 100644
--- a/.github/workflows/_rust.yml
+++ b/.github/workflows/_rust.yml
@@ -42,16 +42,16 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           tool: bpf-linker
-      - run: |
-          cargo +${{ steps.setup-rust.outputs.nightly_version }} udeps --all-targets --all-features ${{ steps.setup-rust.outputs.compile-packages }}
-        name: Check for unused dependencies
-      - run: cargo fmt -- --check
-      - run: cargo doc --all-features --no-deps --document-private-items ${{ steps.setup-rust.outputs.compile-packages }}
-        name: "cargo doc"
-        shell: bash
+
       - run: cargo clippy --all-targets --all-features ${{ steps.setup-rust.outputs.compile-packages }}
-        name: "cargo clippy"
+        name: cargo clippy
         shell: bash
+      - run: cargo doc --all-features --no-deps --document-private-items ${{ steps.setup-rust.outputs.compile-packages }}
+        name: cargo doc
+        shell: bash
+      - run: cargo fmt -- --check
+      - run: cargo +${{ steps.setup-rust.outputs.nightly_version }} udeps --all-targets --all-features ${{ steps.setup-rust.outputs.compile-packages }}
+        name: cargo udeps
       - run: cargo deny check --hide-inclusion-graph --deny unnecessary-skip
         shell: bash