From 9096eee396ff439ce1dde09f268264aebfeb5258 Mon Sep 17 00:00:00 2001 From: Reactor Scram Date: Tue, 30 Jan 2024 15:17:25 -0600 Subject: [PATCH] feat(windows): enable crash handling on release builds (#3441) Since #3263 closed, we could enable crash handling for release builds on Windows, too. This should get rid of a dead code warning in CI: ![image](https://github.com/firezone/firezone/assets/13400041/7a6cd0ed-5943-4fa5-a23f-1426aa438f51) Signed-off-by: Reactor Scram --- rust/windows-client/src-tauri/src/client/crash_handling.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/rust/windows-client/src-tauri/src/client/crash_handling.rs b/rust/windows-client/src-tauri/src/client/crash_handling.rs index b5c49b9ef..c0f18da1d 100755 --- a/rust/windows-client/src-tauri/src/client/crash_handling.rs +++ b/rust/windows-client/src-tauri/src/client/crash_handling.rs @@ -20,7 +20,6 @@ const SOCKET_NAME: &str = "dev.firezone.client.crash_handler"; /// /// Linux has a special `set_ptracer` call that is handy /// MacOS needs a special `ping` call to flush messages inside the crash handler -#[cfg(all(debug_assertions, target_os = "windows"))] pub(crate) fn attach_handler() -> Result { // Attempt to connect to the server let (client, _server) = start_server_and_connect()?; @@ -39,11 +38,6 @@ pub(crate) fn attach_handler() -> Result { Ok(handler) } -#[cfg(not(debug_assertions))] -pub(crate) fn attach_handler() -> Result { - bail!("crash handling is disabled in release builds for now"); -} - /// Main function for the server process, for out-of-process crash handling. /// /// The server process seems to be the preferred method,