diff --git a/rust/connlib/dns-over-tcp/Cargo.toml b/rust/connlib/dns-over-tcp/Cargo.toml index bf2e3d55f..af7a3d1a5 100644 --- a/rust/connlib/dns-over-tcp/Cargo.toml +++ b/rust/connlib/dns-over-tcp/Cargo.toml @@ -20,3 +20,6 @@ futures = { workspace = true } ip_network = { workspace = true } tokio = { workspace = true, features = ["process", "rt", "macros"] } tun = { workspace = true } + +[lints] +workspace = true diff --git a/rust/connlib/dns-over-tcp/src/client.rs b/rust/connlib/dns-over-tcp/src/client.rs index beafffc94..4580a15bf 100644 --- a/rust/connlib/dns-over-tcp/src/client.rs +++ b/rust/connlib/dns-over-tcp/src/client.rs @@ -135,7 +135,7 @@ impl Client { match packet.destination() { IpAddr::V4(v4) if v4 != ipv4_source => return false, IpAddr::V6(v6) if v6 != ipv6_source => return false, - _ => {} + IpAddr::V4(_) | IpAddr::V6(_) => {} } let remote = SocketAddr::new(packet.source(), tcp.source_port()); diff --git a/rust/connlib/dns-over-tcp/src/server.rs b/rust/connlib/dns-over-tcp/src/server.rs index b9ad4ba0a..c9fd9ca3e 100644 --- a/rust/connlib/dns-over-tcp/src/server.rs +++ b/rust/connlib/dns-over-tcp/src/server.rs @@ -182,7 +182,10 @@ impl Server { } for (handle, l3_tcp::AnySocket::Tcp(socket)) in self.sockets.iter_mut() { - let local = self.listen_endpoints.get(&handle).copied().unwrap(); + let Some(local) = self.listen_endpoints.get(&handle).copied() else { + tracing::warn!(%handle, "No listen endpoint for socket"); + continue; + }; let _guard = tracing::trace_span!("socket", %handle).entered(); diff --git a/rust/connlib/dns-over-tcp/tests/client_and_server.rs b/rust/connlib/dns-over-tcp/tests/client_and_server.rs index fbd012f1c..e0a6c0fe6 100644 --- a/rust/connlib/dns-over-tcp/tests/client_and_server.rs +++ b/rust/connlib/dns-over-tcp/tests/client_and_server.rs @@ -1,3 +1,6 @@ +#![allow(clippy::unwrap_used)] +#![allow(clippy::print_stdout)] + use std::{ collections::BTreeSet, net::{Ipv4Addr, Ipv6Addr, SocketAddr, SocketAddrV4}, diff --git a/rust/connlib/dns-over-tcp/tests/smoke_server.rs b/rust/connlib/dns-over-tcp/tests/smoke_server.rs index bc5514a7d..7da5269a0 100644 --- a/rust/connlib/dns-over-tcp/tests/smoke_server.rs +++ b/rust/connlib/dns-over-tcp/tests/smoke_server.rs @@ -1,3 +1,5 @@ +#![allow(clippy::unwrap_used)] + use std::{ collections::BTreeSet, net::{IpAddr, Ipv4Addr, Ipv6Addr, SocketAddr, SocketAddrV4},