From ae3354402f03fee37cc84ebb8275af725ba497c3 Mon Sep 17 00:00:00 2001 From: Jamil Date: Sat, 25 Jan 2025 05:27:08 -0800 Subject: [PATCH] fix(apple): Fix retain cycle in Log.swift (#7861) The previous developer introduced a retain cycle in Log.swift by strongly capturing `self` inside an async closure. --- swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/Log.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/Log.swift b/swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/Log.swift index dccb20a09..f940437d8 100644 --- a/swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/Log.swift +++ b/swift/apple/FirezoneKit/Sources/FirezoneKit/Helpers/Log.swift @@ -196,6 +196,8 @@ private final class LogWriter { jsonData.append(newLineData) - workQueue.async { self.handle.write(jsonData) } + workQueue.async { [weak self] in + self?.handle.write(jsonData) + } } }