From b2b03744b015739b62864803b0c1fb10802e4a1d Mon Sep 17 00:00:00 2001 From: Reactor Scram Date: Tue, 30 Jan 2024 14:51:10 -0600 Subject: [PATCH] fix(windows): Ensure production exes / MSIs don't show "-modified" Git versions (#3432) Fixes #3384 --- .gitattributes | 3 +++ .github/workflows/_rust.yml | 6 ++++++ 2 files changed, 9 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 000000000..001ae320b --- /dev/null +++ b/.gitattributes @@ -0,0 +1,3 @@ +# Don't allow Git to mess up line endings, ever +# https://github.com/actions/checkout/issues/135#issuecomment-613329879 +* -text diff --git a/.github/workflows/_rust.yml b/.github/workflows/_rust.yml index 34770407e..35b4bf7ca 100644 --- a/.github/workflows/_rust.yml +++ b/.github/workflows/_rust.yml @@ -88,6 +88,8 @@ jobs: targets: x86_64-pc-windows-msvc - name: Build release binaries run: | + # Build Windows Tauri GUI + pnpm install # Set logs to debug @@ -107,6 +109,10 @@ jobs: Get-FileHash ${{ env.BINARY_DEST_PATH }}-x64.exe -Algorithm SHA256 | Select-Object Hash > ${{ env.BINARY_DEST_PATH }}-x64.exe.sha256sum.txt Get-FileHash ${{ env.BINARY_DEST_PATH }}-x64.msi -Algorithm SHA256 | Select-Object Hash > ${{ env.BINARY_DEST_PATH }}-x64.msi.sha256sum.txt + + # This might catch regressions in #3384, depending how CI runners + # handle exit codes + git diff --exit-code - name: Save Windows client uses: actions/upload-artifact@v4 with: