From cb37e4aaf4e8776dc8d3af702444166e5008fb84 Mon Sep 17 00:00:00 2001 From: Mark Percival Date: Wed, 1 May 2024 00:10:10 -0400 Subject: [PATCH] Fix: Exclude legacy docs from kb search and vice versa (#4833) When you're searching in KB (v1.0) you don't really want the results from docs and vice versa. There may be a better way to do this on Algolia's side, but this is an easy fix for now. --- website/src/components/DocsSidebar/SearchForm.tsx | 12 ++++++++++++ website/src/components/KbSidebar/SearchForm.tsx | 12 ++++++++++++ 2 files changed, 24 insertions(+) diff --git a/website/src/components/DocsSidebar/SearchForm.tsx b/website/src/components/DocsSidebar/SearchForm.tsx index edf06fe90..7348fbd73 100644 --- a/website/src/components/DocsSidebar/SearchForm.tsx +++ b/website/src/components/DocsSidebar/SearchForm.tsx @@ -2,6 +2,9 @@ import { DocSearch } from "@docsearch/react"; import "@docsearch/css"; export default function SearchForm() { + // Keep /docs search in /docs (pre-1.0), and exclude /kb (>= 1.0) + const excludePathRegex = new RegExp(/^\/kb/) + return (
{ + return items.filter((item) => { + if (item.url) { + const pathname = (new URL(item.url)).pathname + if (pathname.match(excludePathRegex)) return false + } + return true + }) + }} />
); diff --git a/website/src/components/KbSidebar/SearchForm.tsx b/website/src/components/KbSidebar/SearchForm.tsx index edf06fe90..2f9c237f3 100644 --- a/website/src/components/KbSidebar/SearchForm.tsx +++ b/website/src/components/KbSidebar/SearchForm.tsx @@ -2,6 +2,9 @@ import { DocSearch } from "@docsearch/react"; import "@docsearch/css"; export default function SearchForm() { + // Keep /kb search in /kb (>= v1.0), and exclude /docs (pre-1.0) + const excludePathRegex = new RegExp(/^\/docs/) + return (
{ + return items.filter((item) => { + if (item.url) { + const pathname = (new URL(item.url)).pathname + if (pathname.match(excludePathRegex)) return false + } + return true + }) + }} />
);