From da73441d6c75cbc39bc1b7c9888bc26408da749a Mon Sep 17 00:00:00 2001 From: Jamil Date: Sat, 15 Mar 2025 18:09:19 -0500 Subject: [PATCH] fix(swift): Allow too many parameters in onSetInterfaceConfig (#8446) We don't necessarily care if we slightly go over the function parameter count lint in `onSetInterfaceConfig`. --- swift/apple/FirezoneNetworkExtension/Adapter.swift | 1 + swift/apple/FirezoneNetworkExtension/CallbackHandler.swift | 3 ++- swift/apple/FirezoneNetworkExtension/NetworkSettings.swift | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/swift/apple/FirezoneNetworkExtension/Adapter.swift b/swift/apple/FirezoneNetworkExtension/Adapter.swift index 1320fd8ea..85034df46 100644 --- a/swift/apple/FirezoneNetworkExtension/Adapter.swift +++ b/swift/apple/FirezoneNetworkExtension/Adapter.swift @@ -360,6 +360,7 @@ extension Adapter { // MARK: Implementing CallbackHandlerDelegate extension Adapter: CallbackHandlerDelegate { + // swiftlint:disable:next function_parameter_count public func onSetInterfaceConfig( tunnelAddressIPv4: String, tunnelAddressIPv6: String, diff --git a/swift/apple/FirezoneNetworkExtension/CallbackHandler.swift b/swift/apple/FirezoneNetworkExtension/CallbackHandler.swift index 431720583..539fb0863 100644 --- a/swift/apple/FirezoneNetworkExtension/CallbackHandler.swift +++ b/swift/apple/FirezoneNetworkExtension/CallbackHandler.swift @@ -17,6 +17,7 @@ extension RustString: @unchecked Sendable {} extension RustString: Error {} public protocol CallbackHandlerDelegate: AnyObject { + // swiftlint:disable:next function_parameter_count func onSetInterfaceConfig( tunnelAddressIPv4: String, tunnelAddressIPv6: String, @@ -31,7 +32,7 @@ public protocol CallbackHandlerDelegate: AnyObject { public class CallbackHandler { public weak var delegate: CallbackHandlerDelegate? - + // swiftlint:disable:next function_parameter_count func onSetInterfaceConfig( tunnelAddressIPv4: RustString, tunnelAddressIPv6: RustString, diff --git a/swift/apple/FirezoneNetworkExtension/NetworkSettings.swift b/swift/apple/FirezoneNetworkExtension/NetworkSettings.swift index 00174ee8c..7ada8b835 100644 --- a/swift/apple/FirezoneNetworkExtension/NetworkSettings.swift +++ b/swift/apple/FirezoneNetworkExtension/NetworkSettings.swift @@ -36,7 +36,7 @@ class NetworkSettings { guard let domain = domain else { self.matchDomains = [""] self.searchDomains = [""] - return; + return } self.matchDomains = ["", domain]