From dde8b646f09a9636ea221e2699bb6b5f68357905 Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Tue, 12 Mar 2024 08:04:17 +1100 Subject: [PATCH] chore(connlib): remove redundant `action` from `wire` log (#4061) The fields `to` and `from` already indicate that we are either reading or writing. --- rust/connlib/tunnel/src/device_channel.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/connlib/tunnel/src/device_channel.rs b/rust/connlib/tunnel/src/device_channel.rs index 3c7effe0d..cbe15eddf 100644 --- a/rust/connlib/tunnel/src/device_channel.rs +++ b/rust/connlib/tunnel/src/device_channel.rs @@ -94,7 +94,7 @@ impl Device { ) })?; - tracing::trace!(target: "wire", action = "read", from = "device", dest = %packet.destination(), bytes = %packet.packet().len()); + tracing::trace!(target: "wire", from = "device", dest = %packet.destination(), bytes = %packet.packet().len()); Poll::Ready(Ok(packet)) } @@ -127,7 +127,7 @@ impl Device { ) })?; - tracing::trace!(target: "wire", action = "read", from = "device", dest = %packet.destination(), bytes = %packet.packet().len()); + tracing::trace!(target: "wire", from = "device", dest = %packet.destination(), bytes = %packet.packet().len()); Poll::Ready(Ok(packet)) } @@ -175,7 +175,7 @@ impl Device { } pub fn write(&self, packet: IpPacket<'_>) -> io::Result { - tracing::trace!(target: "wire", action = "write", to = "device", bytes = %packet.packet().len()); + tracing::trace!(target: "wire", to = "device", bytes = %packet.packet().len()); match packet { IpPacket::Ipv4Packet(msg) => self.tun.write4(msg.packet()),