From deb47d956e92d64cdeec7aea3356fb7311c6783b Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Fri, 21 Feb 2025 16:24:59 +1100 Subject: [PATCH] chore(gateway): remove log around "No NAT session" (#8227) This is pretty confusing when reading logs. For inbound packets, we assume that if we don't have a NAT session, they belong to the Internet Resource or a CIDR resource, meaning this log shows up for all packets for those resources and even for packets that don't belong to any resource at all. --- rust/connlib/tunnel/src/peer.rs | 6 +++++- rust/connlib/tunnel/src/peer/nat_table.rs | 4 ---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rust/connlib/tunnel/src/peer.rs b/rust/connlib/tunnel/src/peer.rs index 120c7936b..6f0939095 100644 --- a/rust/connlib/tunnel/src/peer.rs +++ b/rust/connlib/tunnel/src/peer.rs @@ -307,7 +307,11 @@ impl ClientOnGateway { return Ok(None); } - TranslateIncomingResult::NoNatSession => return Ok(Some(packet)), + TranslateIncomingResult::NoNatSession => { + // No NAT session means packet is likely for Internet Resource or a CIDR resource. + + return Ok(Some(packet)); + } }; let mut packet = packet diff --git a/rust/connlib/tunnel/src/peer/nat_table.rs b/rust/connlib/tunnel/src/peer/nat_table.rs index ae4bb30fd..7cfe61906 100644 --- a/rust/connlib/tunnel/src/peer/nat_table.rs +++ b/rust/connlib/tunnel/src/peer/nat_table.rs @@ -102,8 +102,6 @@ impl NatTable { return Ok(TranslateIncomingResult::ExpiredNatSession); } - tracing::trace!(?outside, "No active NAT session; skipping translation"); - return Ok(TranslateIncomingResult::NoNatSession); } @@ -117,8 +115,6 @@ impl NatTable { return Ok(TranslateIncomingResult::ExpiredNatSession); } - tracing::trace!(?outside, "No active NAT session; skipping translation"); - Ok(TranslateIncomingResult::NoNatSession) }