From e46cb3f62b66e292f758b9cd4edfad83ad92216a Mon Sep 17 00:00:00 2001
From: Thomas Eizinger <thomas@eizinger.io>
Date: Fri, 29 Nov 2024 00:27:53 +0000
Subject: [PATCH] chore(snownet): improve log when `MessageIntegrity` is
 missing (#7399)

---
 rust/connlib/snownet/src/allocation.rs | 30 ++++++++++++++------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/rust/connlib/snownet/src/allocation.rs b/rust/connlib/snownet/src/allocation.rs
index f9d7f511c..a5e534d20 100644
--- a/rust/connlib/snownet/src/allocation.rs
+++ b/rust/connlib/snownet/src/allocation.rs
@@ -1061,22 +1061,24 @@ impl Allocation {
 
     #[cfg(not(test))]
     fn check_message_integrity(&self, message: &Message<Attribute>) -> bool {
-        message
-            .get_attribute::<MessageIntegrity>()
-            .is_some_and(|mi| {
-                let Some(credentials) = &self.credentials else {
-                    tracing::debug!("Cannot check message integrity without credentials");
+        let Some(mi) = message.get_attribute::<MessageIntegrity>() else {
+            tracing::debug!("Message does not have a `MessageIntegrity` attribute");
 
-                    return false;
-                };
+            return false;
+        };
 
-                mi.check_long_term_credential(
-                    &credentials.username,
-                    &credentials.realm,
-                    &credentials.password,
-                )
-                .is_ok()
-            })
+        let Some(credentials) = &self.credentials else {
+            tracing::debug!("Cannot check message integrity without credentials");
+
+            return false;
+        };
+
+        mi.check_long_term_credential(
+            &credentials.username,
+            &credentials.realm,
+            &credentials.password,
+        )
+        .is_ok()
     }
 }