From ef973bf88de06a48e25e77d92ebb6e719fa6f7bc Mon Sep 17 00:00:00 2001 From: Brian Manifold Date: Fri, 19 Jan 2024 01:34:47 -0500 Subject: [PATCH] Fix radio button toggle on Sites edit page (#3318) Why: * The Sites edit page was toggling the routing option in the page on and off every time a change to the page was made (i.e. every time something was clicked or typed). This was causing the Site to not be editable in certain situations. It ended up being because the form field value being set was not consistently the same type. It would come back as either an atom or a string, but the radio button input was only checking for atoms. Fixes: #3239 --- elixir/apps/web/lib/web/live/sites/edit.ex | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/elixir/apps/web/lib/web/live/sites/edit.ex b/elixir/apps/web/lib/web/live/sites/edit.ex index e437346e6..b6f7ad59e 100644 --- a/elixir/apps/web/lib/web/live/sites/edit.ex +++ b/elixir/apps/web/lib/web/live/sites/edit.ex @@ -55,7 +55,9 @@ defmodule Web.Sites.Edit do field={@form[:routing]} value="managed" label={pretty_print_routing(:managed)} - checked={@form[:routing].value == :managed} + checked={ + @form[:routing].value == :managed || @form[:routing].value == "managed" + } required > <.badge @@ -78,7 +80,9 @@ defmodule Web.Sites.Edit do field={@form[:routing]} value="stun_only" label={pretty_print_routing(:stun_only)} - checked={@form[:routing].value == :stun_only} + checked={ + @form[:routing].value == :stun_only || @form[:routing].value == "stun_only" + } required />