From fa58e2788324d9e24a53addcce28e326df74ec4b Mon Sep 17 00:00:00 2001 From: Thomas Eizinger Date: Tue, 23 Jul 2024 00:53:54 +1000 Subject: [PATCH] refactor(connlib): reduce indentation when looping over gateways (#5944) By leveraging `let-else`, we can perform the main action - pushing to the buffered transmits - on first indentation level of the loop. --- rust/connlib/tunnel/src/tests/sut.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/rust/connlib/tunnel/src/tests/sut.rs b/rust/connlib/tunnel/src/tests/sut.rs index cb91dd162..67014d364 100644 --- a/rust/connlib/tunnel/src/tests/sut.rs +++ b/rust/connlib/tunnel/src/tests/sut.rs @@ -379,10 +379,12 @@ impl TunnelTest { }); for (_, gateway) in self.gateways.iter_mut() { - if let Some(transmit) = gateway.exec_mut(|g| g.sut.poll_transmit()) { - buffered_transmits.push(transmit, gateway); - continue 'outer; - } + let Some(transmit) = gateway.exec_mut(|g| g.sut.poll_transmit()) else { + continue; + }; + + buffered_transmits.push(transmit, gateway); + continue 'outer; } for (id, gateway) in self.gateways.iter_mut() {