diff --git a/elixir/apps/domain/lib/domain/resources/resource/changeset.ex b/elixir/apps/domain/lib/domain/resources/resource/changeset.ex index 6f5a0a6e7..20b385338 100644 --- a/elixir/apps/domain/lib/domain/resources/resource/changeset.ex +++ b/elixir/apps/domain/lib/domain/resources/resource/changeset.ex @@ -5,7 +5,7 @@ defmodule Domain.Resources.Resource.Changeset do @fields ~w[address address_description name type]a @update_fields ~w[name address_description]a - @required_fields ~w[name address address_description type]a + @required_fields ~w[name address type]a def create(%Accounts.Account{} = account, attrs, %Auth.Subject{} = subject) do %Resource{connections: []} @@ -152,8 +152,6 @@ defmodule Domain.Resources.Resource.Changeset do changeset |> validate_length(:name, min: 1, max: 255) |> validate_length(:address_description, min: 1, max: 512) - # TODO: remove once address_description is visible again - |> copy_change(:address, :address_description) |> cast_embed(:filters, with: &cast_filter/2) |> unique_constraint(:ipv4, name: :resources_account_id_ipv4_index) |> unique_constraint(:ipv6, name: :resources_account_id_ipv6_index) diff --git a/elixir/apps/domain/priv/repo/migrations/20240606182241_remove_null_constraint_from_address_description.exs b/elixir/apps/domain/priv/repo/migrations/20240606182241_remove_null_constraint_from_address_description.exs new file mode 100644 index 000000000..093979949 --- /dev/null +++ b/elixir/apps/domain/priv/repo/migrations/20240606182241_remove_null_constraint_from_address_description.exs @@ -0,0 +1,9 @@ +defmodule Domain.Repo.Migrations.RemoveNullConstraintFromAddressDescription do + use Ecto.Migration + + def change do + alter table(:resources) do + modify(:address_description, :string, null: true) + end + end +end diff --git a/elixir/apps/domain/test/domain/resources_test.exs b/elixir/apps/domain/test/domain/resources_test.exs index e5323a859..7842247ed 100644 --- a/elixir/apps/domain/test/domain/resources_test.exs +++ b/elixir/apps/domain/test/domain/resources_test.exs @@ -892,7 +892,6 @@ defmodule Domain.ResourcesTest do assert errors_on(changeset) == %{ name: ["can't be blank"], address: ["can't be blank"], - address_description: ["can't be blank"], type: ["can't be blank"], connections: ["can't be blank"] } @@ -987,8 +986,7 @@ defmodule Domain.ResourcesTest do assert {:ok, resource} = create_resource(attrs, subject) assert resource.address == attrs.address - # TODO: uncomment once we show address_description - # assert resource.address_description == attrs.address_description + assert resource.address_description == attrs.address_description assert resource.name == attrs.address assert resource.account_id == account.id @@ -1021,7 +1019,7 @@ defmodule Domain.ResourcesTest do type: :cidr, name: "mycidr", address: "192.168.1.1/28", - address_description: "192.168.1.1/28" + address_description: "https://google.com" ) assert {:ok, resource} = create_resource(attrs, subject) diff --git a/elixir/apps/web/lib/web/live/resources/edit.ex b/elixir/apps/web/lib/web/live/resources/edit.ex index 9fb3b7351..3dbec8f45 100644 --- a/elixir/apps/web/lib/web/live/resources/edit.ex +++ b/elixir/apps/web/lib/web/live/resources/edit.ex @@ -58,16 +58,15 @@ defmodule Web.Resources.Edit do required /> - -