mirror of
https://github.com/outbackdingo/firezone.git
synced 2026-01-27 18:18:55 +00:00
3dede3d8db
Recently, we changed that we only upload binaries to the draft releases when we actively call the workflow. This means that we may potentially have a drift between: - The commit that gets tagged as the release. - The commit from which the binaries got built. To ensure that this doesn't drift, we only update the draft releases whenever we actually uploaded new binaries to them. In addition, we instruct `release-drafter` to set the target of the release to the commit SHA from when it was triggered. As a result, it is much less error prone that these may drift apart. I believe the only race condition here could be if somebody publishes a release between the time the binaries get uploaded and we update the release draft, i.e. when GitHub hasn't fully finished CI yet. --------- Signed-off-by: Jamil <jamilbk@users.noreply.github.com> Co-authored-by: Jamil <jamilbk@users.noreply.github.com>