Thomas Eizinger 1aa95ed17e fix(connlib): be explicit about unsupported ICMP types (#5611) ...

Our NAT table uses TCP & UDP ports for its entries. To correctly handle
ICMP requests and responses, we use the ICMP identifier in those
packets. All other ICMP messages are currently unsupported.

The errors paths for accessing these fields, i.e. ports for UDP/TCP and
identifier for ICMP currently conflate two different errors:

- Unsupported IP payload: it is neither TCP, UDP or ICMP
- Unsupported ICMP type: it is not an ICMP request or response

This makes certain logs look worse than they are because we say
"Unsupported IP protocol: Icmpv6". To avoid this, we create a dedicated
error variant that calls out the unsupported ICMP type.

Fixes: #5594.

2024-06-28 01:13:25 +00:00

..

proptest-regressions

chore(connlib): implement IP translation according to RFC6145 (#5364)

2024-06-14 21:33:07 +00:00

src

fix(connlib): be explicit about unsupported ICMP types (#5611)

2024-06-28 01:13:25 +00:00

Cargo.toml

chore(connlib): implement some missing ICMP conversions (#5475)

2024-06-24 23:48:14 +00:00