From 036f4bfe28206145b208f716e02b2bc9d792323c Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Thu, 5 Jun 2025 15:08:35 +0200 Subject: [PATCH] hack: fix KUBE_RACE in benchmark-dockerized.sh This fixes the following issue in ci-benchmark-scheduler-perf-master: malformed import path " ": invalid char ' ' FAIL [setup failed] Setting the non-empty string with just a space was broken, the right way to disable the race detector is with an empty KUBE_RACE variable. This worked before when test-integration.sh unconditionally overwrote the KUBE_RACE variable and stopped working when 6cb1488 started to keep whatever was set by the caller. This then caused an empty string to be passed as additional parameter to "go test". --- hack/jenkins/benchmark-dockerized.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hack/jenkins/benchmark-dockerized.sh b/hack/jenkins/benchmark-dockerized.sh index a01dee72279..ea533239f06 100755 --- a/hack/jenkins/benchmark-dockerized.sh +++ b/hack/jenkins/benchmark-dockerized.sh @@ -49,8 +49,9 @@ if [ -n "${KUBE_HACK_TOOLS_GOTOOLCHAIN:-}" ]; then fi GOTOOLCHAIN="${hack_tools_gotoolchain}" go -C "${KUBE_ROOT}/hack/tools" install github.com/cespare/prettybench -# Disable the Go race detector. -export KUBE_RACE=" " +# Disable the Go race detector by explicitly setting it to the empty string (= no argument). +# This is also the default, but let's be explicit in case that this changes later. +export KUBE_RACE="" # Disable coverage report export KUBE_COVER="n" export ARTIFACTS=${ARTIFACTS:-"${WORKSPACE}/artifacts"}