From 7a8854875538ca083de59206447cb150479fa126 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Skocze=C5=84?= Date: Mon, 26 Aug 2024 07:44:52 +0000 Subject: [PATCH] Add workload name to failed threshold log --- test/integration/scheduler_perf/README.md | 2 +- test/integration/scheduler_perf/scheduler_perf.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/integration/scheduler_perf/README.md b/test/integration/scheduler_perf/README.md index 5ca8474fb33..46d7423cad3 100644 --- a/test/integration/scheduler_perf/README.md +++ b/test/integration/scheduler_perf/README.md @@ -158,7 +158,7 @@ the ci-benchmark-scheduler-perf periodic job will fail with an error log such as ``` --- FAIL: BenchmarkPerfScheduling/SchedulingBasic/5000Nodes_10000Pods ... - scheduler_perf.go:1098: ERROR: op 2: expected SchedulingThroughput Average to be higher: got 256.12, want 270 + scheduler_perf.go:1098: ERROR: op 2: SchedulingBasic/5000Nodes_10000Pods/namespace-2: expected SchedulingThroughput Average to be higher: got 256.12, want 270 ``` This allows to analyze which workload failed. Make sure that the failure is not an outlier diff --git a/test/integration/scheduler_perf/scheduler_perf.go b/test/integration/scheduler_perf/scheduler_perf.go index 5b34ec6ce7f..acb5dceb1d1 100644 --- a/test/integration/scheduler_perf/scheduler_perf.go +++ b/test/integration/scheduler_perf/scheduler_perf.go @@ -943,9 +943,9 @@ func compareMetricWithThreshold(items []DataItem, threshold float64, metricSelec for _, item := range items { if item.Labels["Metric"] == metricSelector.Name && labelsMatch(item.Labels, metricSelector.Labels) && !valueWithinThreshold(item.Data["Average"], threshold, metricSelector.ExpectLower) { if metricSelector.ExpectLower { - return fmt.Errorf("expected %s Average to be lower: got %f, want %f", metricSelector.Name, item.Data["Average"], threshold) + return fmt.Errorf("%s: expected %s Average to be lower: got %f, want %f", item.Labels["Name"], metricSelector.Name, item.Data["Average"], threshold) } - return fmt.Errorf("expected %s Average to be higher: got %f, want %f", metricSelector.Name, item.Data["Average"], threshold) + return fmt.Errorf("%s: expected %s Average to be higher: got %f, want %f", item.Labels["Name"], metricSelector.Name, item.Data["Average"], threshold) } } return nil