From ad68a4b4cddc959ea1734398903993e8a2d495a0 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Tue, 10 Jun 2025 19:59:24 -0700 Subject: [PATCH 1/4] emeritus spiffxp spiffxp moved on from the project years ago, he is still missed --- OWNERS_ALIASES | 6 ++++-- build/OWNERS | 3 +-- cmd/kube-controller-manager/OWNERS | 1 - cmd/preferredimports/OWNERS | 1 + hack/OWNERS | 3 +-- pkg/util/coverage/OWNERS | 2 +- test/OWNERS | 2 +- test/conformance/OWNERS | 2 +- test/conformance/image/OWNERS | 3 +-- test/conformance/testdata/OWNERS | 1 - test/e2e/architecture/OWNERS | 2 +- 11 files changed, 12 insertions(+), 14 deletions(-) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index d5a116aaec4..8da0db71e9e 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -217,8 +217,9 @@ aliases: sig-testing-reviewers: - bentheelder - cblecker - - spiffxp - dims + # emeritus: + # - spiffxp sig-node-approvers: - Random-Liu - dchen1107 @@ -553,5 +554,6 @@ aliases: conformance-behavior-approvers: - smarterclayton - johnbelamaric - - spiffxp - dims + # emeritus: + # - spiffpx diff --git a/build/OWNERS b/build/OWNERS index 33d5150d38a..b52ce2f0ecc 100644 --- a/build/OWNERS +++ b/build/OWNERS @@ -14,7 +14,6 @@ reviewers: - palnabarun # Release Manager - puerco # SIG Technical Lead / RelEng subproject owner / Release Manager - saschagrunert # SIG Chair / RelEng subproject owner / Release Manager - - spiffxp - thockin - Verolop # Release Manager - xmudrii # Release Manager @@ -25,10 +24,10 @@ approvers: - justaugustus - liggitt - mikedanese - - spiffxp - thockin emeritus_approvers: - fejta - jbeda + - spiffxp - zmerlynn - lavalamp diff --git a/cmd/kube-controller-manager/OWNERS b/cmd/kube-controller-manager/OWNERS index e10618b19dc..11416b81d12 100644 --- a/cmd/kube-controller-manager/OWNERS +++ b/cmd/kube-controller-manager/OWNERS @@ -29,7 +29,6 @@ reviewers: - sjenning - smarterclayton - soltysh - - spiffxp - sttts - thockin - wojtek-t diff --git a/cmd/preferredimports/OWNERS b/cmd/preferredimports/OWNERS index 1ee6480c5c9..f7f8f6ac295 100644 --- a/cmd/preferredimports/OWNERS +++ b/cmd/preferredimports/OWNERS @@ -5,4 +5,5 @@ reviewers: approvers: - dims - cblecker +emeritus_aprovers: - spiffxp diff --git a/hack/OWNERS b/hack/OWNERS index 88aaa37fecc..8a1266f9829 100644 --- a/hack/OWNERS +++ b/hack/OWNERS @@ -13,7 +13,6 @@ reviewers: - pohly - SataQiu - smarterclayton - - spiffxp - sttts - thockin - wojtek-t @@ -31,7 +30,6 @@ approvers: - SataQiu - smarterclayton - soltysh # for sig-cli related stuff - - spiffxp - sttts - thockin - wojtek-t @@ -43,3 +41,4 @@ emeritus_approvers: - lavalamp - zmerlynn - vishh + - spiffxp diff --git a/pkg/util/coverage/OWNERS b/pkg/util/coverage/OWNERS index 87df89cdb57..74d51577c75 100644 --- a/pkg/util/coverage/OWNERS +++ b/pkg/util/coverage/OWNERS @@ -2,9 +2,9 @@ approvers: - bentheelder - - spiffxp reviewers: - bentheelder +emeritus_approvers: - spiffxp labels: - sig/testing diff --git a/test/OWNERS b/test/OWNERS index e5bda14c730..30a9f63c95e 100644 --- a/test/OWNERS +++ b/test/OWNERS @@ -35,7 +35,6 @@ approvers: - SataQiu - smarterclayton - soltysh - - spiffxp - sttts - thockin - wojtek-t @@ -56,6 +55,7 @@ emeritus_approvers: - ncdc - vishh - shyamjvs + - spiffxp - enisoc - alejandrox1 - timothysc diff --git a/test/conformance/OWNERS b/test/conformance/OWNERS index a410bf66e16..c14c85896a5 100644 --- a/test/conformance/OWNERS +++ b/test/conformance/OWNERS @@ -7,9 +7,9 @@ reviewers: - johnbelamaric approvers: - cheftako - - spiffxp - johnbelamaric emeritus_approvers: + - spiffxp labels: - area/conformance - sig/architecture diff --git a/test/conformance/image/OWNERS b/test/conformance/image/OWNERS index 8fdc8ef2545..67afc3f43ea 100644 --- a/test/conformance/image/OWNERS +++ b/test/conformance/image/OWNERS @@ -2,17 +2,16 @@ reviewers: - dims - - spiffxp - bentheelder - johnSchnake approvers: - dims - - spiffxp - bentheelder emeritus_approvers: - ixdy - timothysc - neolit123 + - spiffxp labels: - sig/release - sig/testing diff --git a/test/conformance/testdata/OWNERS b/test/conformance/testdata/OWNERS index fdc485482d7..23ab6f4fcaa 100644 --- a/test/conformance/testdata/OWNERS +++ b/test/conformance/testdata/OWNERS @@ -5,7 +5,6 @@ options: no_parent_owners: true reviewers: - smarterclayton - - spiffxp - dims - johnbelamaric approvers: diff --git a/test/e2e/architecture/OWNERS b/test/e2e/architecture/OWNERS index 44aad16962a..ac5531b97d5 100644 --- a/test/e2e/architecture/OWNERS +++ b/test/e2e/architecture/OWNERS @@ -8,9 +8,9 @@ reviewers: - johnbelamaric approvers: - cheftako - - spiffxp - johnbelamaric emeritus_approvers: + - spiffxp labels: - area/conformance - sig/architecture From 1dd055774cdd541dbc73ea635274a884ff0dd786 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Tue, 10 Jun 2025 20:00:15 -0700 Subject: [PATCH 2/4] backfill some sig-testing-reviewers (tech leads aojea and pohly) --- OWNERS_ALIASES | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index 8da0db71e9e..d3166c3fadb 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -215,9 +215,11 @@ aliases: - seans3 - soltysh sig-testing-reviewers: + - aojea - bentheelder - cblecker - dims + - pohly # emeritus: # - spiffxp sig-node-approvers: From 00a6d2c99c05ba33185738be3465c99b6bd58aa8 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Tue, 10 Jun 2025 20:05:25 -0700 Subject: [PATCH 3/4] add bentheelder to conformance related test *reviewers* To backfill from removing spiffxp. I have been active in Kubernetes testing and conformance related discussions and PRs for 8+ years now and I am a SIG Testing TL. I'd lke to help review these additional directories. I already approve the test/, including nearly all of the e2e tests and images, and the conformance image in particular for many years now. --- test/conformance/OWNERS | 1 + test/conformance/testdata/OWNERS | 1 + test/e2e/architecture/OWNERS | 1 + 3 files changed, 3 insertions(+) diff --git a/test/conformance/OWNERS b/test/conformance/OWNERS index c14c85896a5..5d4ce8f5f19 100644 --- a/test/conformance/OWNERS +++ b/test/conformance/OWNERS @@ -2,6 +2,7 @@ # This is the owner of the test code. The test data itself is owned by sig-architecture. reviewers: + - bentheelder - cheftako - oomichi - johnbelamaric diff --git a/test/conformance/testdata/OWNERS b/test/conformance/testdata/OWNERS index 23ab6f4fcaa..9e008af8062 100644 --- a/test/conformance/testdata/OWNERS +++ b/test/conformance/testdata/OWNERS @@ -4,6 +4,7 @@ options: no_parent_owners: true reviewers: + - bentheelder - smarterclayton - dims - johnbelamaric diff --git a/test/e2e/architecture/OWNERS b/test/e2e/architecture/OWNERS index ac5531b97d5..dcb55df90e7 100644 --- a/test/e2e/architecture/OWNERS +++ b/test/e2e/architecture/OWNERS @@ -3,6 +3,7 @@ # This is the owner of the test code. The test data itself is owned by sig-architecture. reviewers: - aojea + - bentheelder - cheftako - oomichi - johnbelamaric From 2810f6e65f53eb0691544c8dae86a16d0f224327 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Tue, 10 Jun 2025 20:07:43 -0700 Subject: [PATCH 4/4] add bentheelder to cmd/preferredimports *reviewers* I'm not sure the one remaining reviewer is active, I am active in code organization and build + test tooling for many years now. --- cmd/preferredimports/OWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/preferredimports/OWNERS b/cmd/preferredimports/OWNERS index f7f8f6ac295..768d003b926 100644 --- a/cmd/preferredimports/OWNERS +++ b/cmd/preferredimports/OWNERS @@ -2,6 +2,7 @@ reviewers: - johnSchnake + - BenTheElder approvers: - dims - cblecker