mirror of
https://github.com/outbackdingo/kubernetes.git
synced 2026-02-23 11:27:15 +00:00
1cf6ef08df
Automatic merge from submit-queue CRI: Stop following container log when container exited. Fixes https://github.com/kubernetes/kubernetes/issues/44340. This PR changed kubelet to periodically check whether container is running when following container logs, and stop following when container exited. I've tried this PR in my local cluster: ``` Wed Apr 12 20:23:54 UTC 2017 Wed Apr 12 20:23:58 UTC 2017 Wed Apr 12 20:24:02 UTC 2017 Wed Apr 12 20:24:06 UTC 2017 Wed Apr 12 20:24:10 UTC 2017 Wed Apr 12 20:24:14 UTC 2017 Wed Apr 12 20:24:18 UTC 2017 Wed Apr 12 20:24:22 UTC 2017 Wed Apr 12 20:24:26 UTC 2017 Wed Apr 12 20:24:30 UTC 2017 Wed Apr 12 20:24:34 UTC 2017 Wed Apr 12 20:24:38 UTC 2017 Wed Apr 12 20:24:42 UTC 2017 Wed Apr 12 20:24:46 UTC 2017 failed to wait logs for log file "/var/log/pods/1d54634c7b31346fc3219f5e0b7507cc/nginx_0.log": container "b9a17a2c53550c3703ab350d85911743af8bf164a41813544fd08fb9585f7501" is not running (state="CONTAINER_EXITED") ``` The only difference is that `ReadLogs` will return error when container exits during following. I'm not sure whether we should get rid of it or not. @yujuhong @feiskyer @JorritSalverda /cc @kubernetes/sig-node-bugs **Release note**: ```release-note `kubectl logs -f` now stops following when container stops. ```