mirror of
https://github.com/outbackdingo/kubernetes.git
synced 2026-02-20 09:50:57 +00:00
94f4f06d13
The attach goroutine can currently t.Log/t.Error during or after the
subtest completion. This causes races like:
```
==================
WARNING: DATA RACE
Read at 0x00c000e90ac3 by goroutine 1231:
testing.(*common).logDepth()
GOROOT/src/testing/testing.go:736 +0xa9
testing.(*common).log()
GOROOT/src/testing/testing.go:729 +0x8f
testing.(*common).Logf()
GOROOT/src/testing/testing.go:775 +0x21
k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21.1()
pkg/volume/csi/csi_test.go:313 +0x1a4
Previous write at 0x00c000e90ac3 by goroutine 875:
testing.tRunner.func1()
GOROOT/src/testing/testing.go:1113 +0x484
testing.tRunner()
GOROOT/src/testing/testing.go:1131 +0x22a
testing.tRunner()
GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 1231 (running) created at:
k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll.func21()
pkg/volume/csi/csi_test.go:307 +0xf05
testing.tRunner()
GOROOT/src/testing/testing.go:1127 +0x202
Goroutine 875 (running) created at:
testing.(*T).Run()
GOROOT/src/testing/testing.go:1178 +0x796
k8s.io/kubernetes/pkg/volume/csi.TestCSI_VolumeAll()
pkg/volume/csi/csi_test.go:223 +0xb2c
testing.tRunner()
GOROOT/src/testing/testing.go:1127 +0x202
==================
```
See also this comment:
07c1788357/src/testing/testing.go (L1141-L1142)
Noticed in:
https://github.com/kubernetes/kubernetes/pull/94449
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/94449/pull-kubernetes-bazel-test/1304519003330318337