mirror of
https://github.com/outbackdingo/kubernetes.git
synced 2026-02-26 21:00:35 +00:00
8f9e8c0acf
Automatic merge from submit-queue (batch tested with PRs 60208, 60084, 60183, 59713, 60096). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix race condition issue when detaching azure disk **What this PR does / why we need it**: add lock before detaching azure disk, without this PR, there would be lots of `Multi-Attach error` when scheduling one pod from one node to another. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60101 **Special notes for your reviewer**: @feiskyer @djsly @khenidak Since we are using `getLunMutex.LockKey(instanceid)` for both AttachDisk and DetachDisk, there would be only one VM.update operation at a time for both AttachDisk and DetachDisk. **Release note**: ``` fix race condition issue when detaching azure disk ``` /assign @feiskyer Could you also mark as v1.10 milestone @feiskyer thanks. /sig azure