diff --git a/src/config.c b/src/config.c index a9b64bf..86bfb83 100644 --- a/src/config.c +++ b/src/config.c @@ -141,31 +141,6 @@ void read_key_from_file (const char *fname, char *buf, size_t buflen) ParodusInfo ("%d bytes read\n", nbytes); } -void execute_token_script(char *token, char *name, size_t len, char *mac, char *serNum) -{ - FILE* out = NULL, *file = NULL; - char command[MAX_BUF_SIZE] = {'\0'}; - if(strlen(name)>0) - { - file = fopen(name, "r"); - if(file) - { - snprintf(command,sizeof(command),"%s %s %s",name,serNum,mac); - out = popen(command, "r"); - if(out) - { - fgets(token, len, out); - pclose(out); - } - fclose(file); - } - else - { - ParodusError ("File %s open error\n", name); - } - } -} - // strips ':' characters // verifies that there exactly 12 characters int parse_mac_address (char *target, const char *arg) @@ -386,9 +361,7 @@ int parseCommandLine(int argc,char **argv,ParodusCfg * cfg) {"ssl-cert-path", required_argument, 0, 'c'}, {"force-ipv4", no_argument, 0, '4'}, {"force-ipv6", no_argument, 0, '6'}, - {"token-read-script", required_argument, 0, 'T'}, {"boot-time-retry-wait", required_argument, 0, 'w'}, - {"token-acquisition-script", required_argument, 0, 'J'}, {"client-cert-path", required_argument, 0, 'P'}, {"token-server-url", required_argument, 0, 'U'}, {"crud-config-file", required_argument, 0, 'C'}, @@ -550,14 +523,6 @@ int parseCommandLine(int argc,char **argv,ParodusCfg * cfg) cfg->flags |= FLAGS_IPV6_ONLY; break; - case 'J': - parStrncpy(cfg->token_acquisition_script, optarg,sizeof(cfg->token_acquisition_script)); - break; - - case 'T': - parStrncpy(cfg->token_read_script, optarg,sizeof(cfg->token_read_script)); - break; - case 'w': cfg->boot_retry_wait = parse_num_arg (optarg, "boot-time-retry-wait"); ParodusInfo("boot_retry_wait is %d\n",cfg->boot_retry_wait); @@ -850,24 +815,6 @@ void loadParodusCfg(ParodusCfg * config,ParodusCfg *cfg) ParodusPrint("cert_path is NULL. set to empty\n"); } - if(strlen(config->token_acquisition_script )!=0) - { - parStrncpy(cfg->token_acquisition_script, config->token_acquisition_script,sizeof(cfg->token_acquisition_script)); - } - else - { - ParodusPrint("token_acquisition_script is NULL. read from tmp file\n"); - } - - if(strlen(config->token_read_script )!=0) - { - parStrncpy(cfg->token_read_script, config->token_read_script,sizeof(cfg->token_read_script)); - } - else - { - ParodusPrint("token_read_script is NULL. read from tmp file\n"); - } - cfg->boot_time = config->boot_time; cfg->webpa_ping_timeout = config->webpa_ping_timeout; cfg->webpa_backoff_max = config->webpa_backoff_max; diff --git a/tests/test_config.c b/tests/test_config.c index 65e1136..0a7e0b0 100644 --- a/tests/test_config.c +++ b/tests/test_config.c @@ -37,7 +37,6 @@ extern int parse_webpa_url (const char *full_url, char **server_addr, unsigned int *port); extern unsigned int get_algo_mask (const char *algo_str); extern unsigned int parse_num_arg (const char *arg, const char *arg_name); -extern void execute_token_script(char *token, char *name, size_t len, char *mac, char *serNum); extern void createNewAuthToken(char *newToken, size_t len); /*----------------------------------------------------------------------------*/ @@ -184,8 +183,6 @@ void test_parseCommandLine() #endif "--force-ipv4", "--force-ipv6", - "--token-read-script=/tmp/token.sh", - "--token-acquisition-script=/tmp/token.sh", "--ssl-cert-path=/etc/ssl/certs/ca-certificates.crt", #ifdef FEATURE_DNS_QUERY "--acquire-jwt=1", @@ -317,8 +314,6 @@ void test_loadParodusCfg() Cfg->jwt_algo = 1025; parStrncpy(Cfg->jwt_key, "AGdyuwyhwl2ow2ydsoioiygkshwdthuwd",sizeof(Cfg->jwt_key)); #endif - parStrncpy(Cfg->token_acquisition_script , "/tmp/token.sh", sizeof(Cfg->token_acquisition_script)); - parStrncpy(Cfg->token_read_script , "/tmp/token.sh", sizeof(Cfg->token_read_script)); parStrncpy(Cfg->cert_path, "/etc/ssl.crt",sizeof(Cfg->cert_path)); #ifdef ENABLE_SESHAT parStrncpy(Cfg->seshat_url, "ipc://tmp/seshat_service.url", sizeof(Cfg->seshat_url)); @@ -340,8 +335,6 @@ void test_loadParodusCfg() assert_int_equal( (int) tmpcfg.jwt_algo, 1025); assert_string_equal(tmpcfg.jwt_key, "AGdyuwyhwl2ow2ydsoioiygkshwdthuwd"); #endif - assert_string_equal( tmpcfg.token_acquisition_script,"/tmp/token.sh"); - assert_string_equal( tmpcfg.token_read_script,"/tmp/token.sh"); assert_string_equal(tmpcfg.cert_path, "/etc/ssl.crt"); #ifdef ENABLE_SESHAT assert_string_equal(tmpcfg.seshat_url, "ipc://tmp/seshat_service.url"); @@ -553,20 +546,7 @@ void test_get_algo_mask () #endif } -void test_execute_token_script() -{ - char *cmd1 = "../../tests/return_ser_mac.bsh"; - char *cmd2 = "nosuch"; - char token[32]; - - memset (token, '\0', sizeof(token)); - execute_token_script (token, cmd1, sizeof(token), "mac123", "ser456"); - assert_string_equal (token, "SER_MAC ser456 mac123"); - - memset (token, '\0', sizeof(token)); - execute_token_script (token, cmd2, sizeof(token), "mac123", "ser456"); - assert_string_equal (token, ""); -} + void test_new_auth_token () { @@ -618,7 +598,6 @@ int main(void) //cmocka_unit_test(test_parodusGitVersion), cmocka_unit_test(test_setDefaultValuesToCfg), cmocka_unit_test(err_setDefaultValuesToCfg), - cmocka_unit_test(test_execute_token_script), cmocka_unit_test(test_new_auth_token) };