mirror of
https://github.com/outbackdingo/proxmox-cloud-controller-manager.git
synced 2026-01-27 18:20:07 +00:00
fix: makefile conformance stage
Add make conformance command. Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
This commit is contained in:
@@ -9,10 +9,9 @@ policies:
|
|||||||
body:
|
body:
|
||||||
required: true
|
required: true
|
||||||
dco: true
|
dco: true
|
||||||
gpg: false
|
|
||||||
spellcheck:
|
spellcheck:
|
||||||
locale: US
|
locale: US
|
||||||
maximumOfOneCommit: false
|
maximumOfOneCommit: true
|
||||||
conventional:
|
conventional:
|
||||||
types:
|
types:
|
||||||
- build
|
- build
|
||||||
|
|||||||
2
.github/workflows/conform.yaml
vendored
2
.github/workflows/conform.yaml
vendored
@@ -21,3 +21,5 @@ jobs:
|
|||||||
|
|
||||||
- name: Conform action
|
- name: Conform action
|
||||||
uses: talos-systems/conform@v0.1.0-alpha.30
|
uses: talos-systems/conform@v0.1.0-alpha.30
|
||||||
|
with:
|
||||||
|
token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -1,5 +1,15 @@
|
|||||||
# Contributing
|
# Contributing
|
||||||
|
|
||||||
|
## Pull Requests
|
||||||
|
|
||||||
|
All PRs require a single commit.
|
||||||
|
|
||||||
|
Having one commit in a Pull Request is very important for several reasons:
|
||||||
|
* A single commit per PR keeps the git history clean and readable.
|
||||||
|
It helps reviewers and future developers understand the change as one atomic unit of work, instead of sifting through many intermediate or redundant commits.
|
||||||
|
* One commit is easier to cherry-pick into another branch or to track in changelogs.
|
||||||
|
* Squashing into one meaningful commit ensures the final PR only contains what matters.
|
||||||
|
|
||||||
## Developer Certificate of Origin
|
## Developer Certificate of Origin
|
||||||
|
|
||||||
All commits require a [DCO](https://developercertificate.org/) sign-off.
|
All commits require a [DCO](https://developercertificate.org/) sign-off.
|
||||||
|
|||||||
4
Makefile
4
Makefile
@@ -81,6 +81,10 @@ lint: ## Lint Code
|
|||||||
unit: ## Unit Tests
|
unit: ## Unit Tests
|
||||||
go test -tags=unit $(shell go list ./...) $(TESTARGS)
|
go test -tags=unit $(shell go list ./...) $(TESTARGS)
|
||||||
|
|
||||||
|
.PHONY: conformance
|
||||||
|
conformance: ## Conformance
|
||||||
|
docker run --rm -it -v $(PWD):/src -w /src ghcr.io/siderolabs/conform:v0.1.0-alpha.30 enforce
|
||||||
|
|
||||||
############
|
############
|
||||||
|
|
||||||
.PHONY: helm-unit
|
.PHONY: helm-unit
|
||||||
|
|||||||
Reference in New Issue
Block a user