github-personal/talos-cloud-controller-manager
1
0
Fork 0
mirror of https://github.com/outbackdingo/talos-cloud-controller-manager.git synced 2026-01-27 10:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: node spec ip

Browse Source 
Always update the node IPs.
Network ip/hostname can change after node eviction (spot instance).

Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
This commit is contained in:
Serge Logvinov
2023-04-05 22:12:00 +03:00
parent 8583f5959f
commit 7a039d9f13
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/talos/instances.go
View File

@@ -48,13 +48,6 @@ func (i *instances) InstanceShutdown(_ context.Context, node *v1.Node) (bool, er
func (i *instances) InstanceMetadata(ctx context.Context, node *v1.Node) (*cloudprovider.InstanceMetadata, error) {
klog.V(4).Info("instances.InstanceMetadata() called, node: ", node.Name)
// Skip initialized nodes.
if i.c.config.Global.SkipForeignNode && !strings.HasPrefix(node.Spec.ProviderID, ProviderName) {
klog.V(4).Infof("instances.InstanceMetadata() node %s has providerID: %s, skipped", node.Name, node.Spec.ProviderID)
return &cloudprovider.InstanceMetadata{}, nil
}
if providedIP, ok := node.ObjectMeta.Annotations[cloudproviderapi.AnnotationAlphaProvidedIPAddr]; ok {
meta, err := i.c.getNodeMetadata(ctx, providedIP)
if err != nil {
@@ -81,8 +74,13 @@ func (i *instances) InstanceMetadata(ctx context.Context, node *v1.Node) (*cloud
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeInternalDNS, Address: meta.Hostname})
}
if err := syncNodeLabels(i.c, node, meta); err != nil {
klog.Errorf("failed update labels for node %s, %w", node.Name, err)
// Skip initialized nodes.
if i.c.config.Global.SkipForeignNode && !strings.HasPrefix(node.Spec.ProviderID, ProviderName) {
klog.V(4).Infof("instances.InstanceMetadata() node %s has foreign providerID: %s, skipped", node.Name, node.Spec.ProviderID)
if err := syncNodeLabels(i.c, node, meta); err != nil {
klog.Errorf("failed update labels for node %s, %w", node.Name, err)
}
}
return &cloudprovider.InstanceMetadata{