From 73914d1df8a36f32e2df337ca9b8877e0fcf5e05 Mon Sep 17 00:00:00 2001 From: DrPsychick Date: Thu, 15 Aug 2024 12:49:41 +0200 Subject: [PATCH 1/2] fix: PATCH /user will overwrite existing "forward_destination" --- core/admin/mailu/api/v1/user.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/admin/mailu/api/v1/user.py b/core/admin/mailu/api/v1/user.py index b0c9d4da..f4667ea5 100644 --- a/core/admin/mailu/api/v1/user.py +++ b/core/admin/mailu/api/v1/user.py @@ -242,8 +242,7 @@ class User(Resource): if 'forward_enabled' in data: user_found.forward_enabled = data['forward_enabled'] if 'forward_destination' in data and len(data['forward_destination']) > 0: - if len(data['forward_destination']) == 0: - user_found.forward_destination = data['forward_destination'] + user_found.forward_destination = data['forward_destination'] if 'forward_keep' in data: user_found.forward_keep = data['forward_keep'] if 'reply_enabled' in data: From b1e31a69a210b730ffce1198efc221bf81b187fc Mon Sep 17 00:00:00 2001 From: DrPsychick Date: Thu, 15 Aug 2024 12:52:58 +0200 Subject: [PATCH 2/2] fix: add changelog entry --- towncrier/newsfragments/3374.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 towncrier/newsfragments/3374.bugfix diff --git a/towncrier/newsfragments/3374.bugfix b/towncrier/newsfragments/3374.bugfix new file mode 100644 index 00000000..b244308f --- /dev/null +++ b/towncrier/newsfragments/3374.bugfix @@ -0,0 +1 @@ +Fix a bug preventing user "forward_destination" to be updated with a PATCH request \ No newline at end of file