From 030e44309461552a18427ef1924e193bfc660106 Mon Sep 17 00:00:00 2001 From: Scott Collyer Date: Wed, 1 Nov 2017 09:04:04 -0700 Subject: [PATCH] coral: Fix charging LED color for Robo Robo's LED spec is Red <= 5%, Orange 6 < SOC < 97, Green >= 97%. However, the table had Orange and Green flipped. This CL corrects that error. BUG=b:64192049 BRANCH=coral TEST=Used EC console battfake command to verify that charge LED color is red until 5%, then orange until 94%, and green after that. Note the 94% limit is due to the define CONFIG_BATTERY_LEVEL_NEAR_FULL which is set to 94 as that's when the battery will want charging again after reaching 100%. Change-Id: Ia8395d6ca28ab000e12fb7a43f13721c7959e35d Signed-off-by: Scott Collyer Reviewed-on: https://chromium-review.googlesource.com/748971 Commit-Ready: Scott Collyer Tested-by: Scott Collyer Reviewed-by: Aaron Durbin --- board/coral/led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/coral/led.c b/board/coral/led.c index 91100a3f44..94914db389 100644 --- a/board/coral/led.c +++ b/board/coral/led.c @@ -98,8 +98,8 @@ static const struct led_descriptor led_default_state_table[][LED_NUM_PHASES] = { /* COLOR_1 = Green, COLOR_2 = Red */ static const struct led_descriptor led_robo_state_table[][LED_NUM_PHASES] = { { {LED_COLOR_2, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} }, - { {LED_COLOR_1, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} }, { {LED_COLOR_BOTH, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} }, + { {LED_COLOR_1, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} }, { {LED_OFF, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} }, { {LED_OFF, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} }, { {LED_OFF, LED_INDEFINITE}, {LED_OFF, LED_INDEFINITE} },