From 198fd7f2c2cc09df0bc28406051a14b2c8bd401c Mon Sep 17 00:00:00 2001 From: Scott Date: Thu, 23 Jul 2015 18:59:41 -0700 Subject: [PATCH] oak: Fix issue with pc_send_ec_int() function There was a bug in this function where the bit for host_command was being set in the ec_status variable. This caused the ALERT# GPIO line to be held low which in turn caused the EC MCU to loop and keep reading the ALERT register. BUG=none BRANCH=none TEST=manual Tested against Zinger in both ports and Zinger and Samus at connected into each port. Verified that it established a PD contract for both ports and that the alert line was no longer being held low Change-Id: I5540440a68581521eb002411f728a4eac2f22caf Signed-off-by: Scott Collyer Reviewed-on: https://chromium-review.googlesource.com/288252 Reviewed-by: Alec Berg Commit-Queue: Alec Berg Tested-by: Alec Berg --- board/oak_pd/board.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/board/oak_pd/board.c b/board/oak_pd/board.c index df550b4e26..4b37a1efb2 100644 --- a/board/oak_pd/board.c +++ b/board/oak_pd/board.c @@ -25,8 +25,6 @@ static uint32_t ec_int_status; void pd_send_ec_int(void) { - /* Indicate that ec_int gpio is active due to host command */ - atomic_or(&ec_int_status, PD_STATUS_HOST_EVENT); /* If any sources are active, then drive the line low */ gpio_set_level(GPIO_EC_INT, !ec_int_status);