From 268ca52daa5e63abcfe804c7316f412b0fe792f3 Mon Sep 17 00:00:00 2001 From: Mary Ruthven Date: Fri, 17 Jun 2016 17:09:51 -0700 Subject: [PATCH] cr50: Add pull down on UART TX signals We need to have an internal pull down so the UART TX signals will be pulled low when servo is disconnected. BUG=chrome-os-partner:54547 BRANCH=none TEST=On gru test that servo detection works. Change-Id: I7d549766273862eb23c0645b887f3db4a0adbab1 Signed-off-by: Mary Ruthven Reviewed-on: https://chromium-review.googlesource.com/353764 Commit-Ready: Vadim Bendebury Tested-by: Vadim Bendebury Reviewed-by: Bill Richardson Reviewed-by: Vadim Bendebury --- board/cr50/gpio.inc | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/board/cr50/gpio.inc b/board/cr50/gpio.inc index a255391b59..a0381021fb 100644 --- a/board/cr50/gpio.inc +++ b/board/cr50/gpio.inc @@ -15,15 +15,19 @@ * boards that don't have an external pullup don't trigger due to noise. */ GPIO_INT(SYS_RST_L_IN, PIN(1, 0), GPIO_INT_FALLING | GPIO_PULL_UP, - sys_rst_asserted) + sys_rst_asserted) GPIO_INT(AP_ON, PIN(1, 1), GPIO_INT_RISING, device_state_on) GPIO_INT(EC_ON, PIN(1, 2), GPIO_INT_RISING, device_state_on) -GPIO_INT(SERVO_UART1_ON, PIN(1, 3), GPIO_INT_RISING, device_state_on) -GPIO_INT(SERVO_UART2_ON, PIN(1, 4), GPIO_INT_RISING, device_state_on) +GPIO_INT(SERVO_UART1_ON, PIN(1, 3), GPIO_INT_RISING | GPIO_PULL_DOWN, + device_state_on) +GPIO_INT(SERVO_UART2_ON, PIN(1, 4), GPIO_INT_RISING | GPIO_PULL_DOWN, + device_state_on) GPIO_INT(AP_OFF, PIN(1, 5), GPIO_INT_FALLING, device_state_off) GPIO_INT(EC_OFF, PIN(1, 6), GPIO_INT_FALLING, device_state_off) -GPIO_INT(SERVO_UART1_OFF, PIN(1, 7), GPIO_INT_FALLING, device_state_off) -GPIO_INT(SERVO_UART2_OFF, PIN(1, 8), GPIO_INT_FALLING, device_state_off) +GPIO_INT(SERVO_UART1_OFF, PIN(1, 7), GPIO_INT_FALLING | GPIO_PULL_DOWN, + device_state_off) +GPIO_INT(SERVO_UART2_OFF, PIN(1, 8), GPIO_INT_FALLING | GPIO_PULL_DOWN, + device_state_off) /* Pull this low to interrupt the AP */ GPIO(INT_AP_L, PIN(0, 0), GPIO_INPUT)