From 27a096870398748861537ff00bc4bdfd05685276 Mon Sep 17 00:00:00 2001 From: Vic Yang Date: Tue, 8 Jul 2014 16:19:55 -0700 Subject: [PATCH] mec1322: reports actual GPIO level for output pins For open-drain output pins, this would allow us to easily check pin state without changing it to input. BUG=chrome-os-partner:26483 TEST=Toggle output level and read it back. BRANCH=None Change-Id: Ia7ceb7a221a8f0cfec9b19a5c5baae4d5441150f Signed-off-by: Vic Yang Reviewed-on: https://chromium-review.googlesource.com/207060 Reviewed-by: Randall Spangler --- chip/mec1322/gpio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/chip/mec1322/gpio.c b/chip/mec1322/gpio.c index 73b584a943..1be969e60c 100644 --- a/chip/mec1322/gpio.c +++ b/chip/mec1322/gpio.c @@ -54,10 +54,7 @@ test_mockable int gpio_get_level(enum gpio_signal signal) i = 31 - __builtin_clz(mask); val = MEC1322_GPIO_CTL(gpio_list[signal].port, i); - if (val & (1 << 9)) /* Output */ - return (val & (1 << 16)) ? 1 : 0; - else - return (val & (1 << 24)) ? 1 : 0; + return (val & (1 << 24)) ? 1 : 0; } void gpio_set_level(enum gpio_signal signal, int value)