From 2a149154c4e5d06aa9fc3a007cca05890e09e583 Mon Sep 17 00:00:00 2001 From: Nicolas Boichat Date: Wed, 8 Mar 2017 11:24:53 -0800 Subject: [PATCH] hammer: Enable internal pull-up on UART RX line Prevent spurious wake when servo is not connected. BRANCH=none BUG=b:36119938 TEST=Measure pull up value with a multimeter when servo is not connected: value around 30k when host in S0 and S3. Change-Id: I8bd54e4dcfd5c65f1f0cd32ffd4a70cedb979cc2 Reviewed-on: https://chromium-review.googlesource.com/452652 Commit-Ready: Nicolas Boichat Tested-by: Nicolas Boichat Reviewed-by: Vincent Palatin --- board/hammer/gpio.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/hammer/gpio.inc b/board/hammer/gpio.inc index bc8dbdfd0b..6ab26af4ec 100644 --- a/board/hammer/gpio.inc +++ b/board/hammer/gpio.inc @@ -52,7 +52,7 @@ GPIO(WP_L, PIN(A, 13), GPIO_INPUT) /* Unimplemented signals since we are not an EC */ UNIMPLEMENTED(ENTERING_RW) -ALTERNATE(PIN_MASK(A, 0x0600), 1, MODULE_UART, 0) /* USART1: PA09/PA10 - Servo stm32 console UART */ +ALTERNATE(PIN_MASK(A, 0x0600), 1, MODULE_UART, GPIO_PULL_UP) /* USART1: PA09/PA10 - Servo stm32 console UART */ ALTERNATE(PIN_MASK(B, 0x00c0), 1, MODULE_I2C, 0) /* I2C MASTER:PB6/7 GPIO_ODR_HIGH */