From 2bee304abda0f51bbc3d673daae26e583fb7ca55 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Tue, 17 Jul 2012 16:24:16 -0700 Subject: [PATCH] Remove the keyboard "cold reset" hack This was needed because we could not do a clean reset with CF9 and were relying on the keyboard reset pulse to trigger a cold reset. However it has the downside of causing a kernel panic to be a cold reset and the kernel panic information in memory is lost. Now that we have a VR workaround this hack can be disabled and the keyboard can instead issue a warm reset. BUG=chrome-os-partner:11036 TEST=manual 1) install this EC on a Link device and boot 2) log in and execute "echo panic > /proc/breakme" 3) after reboot look for kernel entry in /var/spool/crash Change-Id: I1134618f0a202d37aaae69a1d857fa8853a7e52c Signed-off-by: Duncan Laurie Reviewed-on: https://gerrit.chromium.org/gerrit/27722 Reviewed-by: Vincent Palatin Reviewed-by: Randall Spangler --- common/keyboard.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/common/keyboard.c b/common/keyboard.c index ccd0da63b1..76e2c4b2dd 100644 --- a/common/keyboard.c +++ b/common/keyboard.c @@ -596,10 +596,7 @@ int handle_keyboard_command(uint8_t command, uint8_t *output) #ifdef CONFIG_TASK_X86POWER case I8042_SYSTEM_RESET: - /* Trigger a cold reset, since that also resets the TPM. If we - * just trigger a warm reset, that doesn't assert PLTRST# and - * the TPM is not reset. See crosbug.com/p/8379. */ - x86_power_reset(1); + x86_power_reset(0); break; #endif