From 2c162ddade721473eb3fbe7d6ae139def581af2c Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Thu, 5 May 2016 09:53:28 -0700 Subject: [PATCH] test: host: Fix sbc_charging_v2 test failure sb_i2c_xfer() assumes 'out' is a valid pointer, which is only true if out_size is non-zero. BUG=chrome-os-partner:51207 BRANCH=glados TEST=`make buildall -j` w/ https://chromium-review.googlesource.com/#/c/342630/ Signed-off-by: Shawn Nematbakhsh Change-Id: Ia22dcca2b5318b4d69c7afa49f5c8891ab329bd1 Reviewed-on: https://chromium-review.googlesource.com/342635 Commit-Ready: Shawn N Tested-by: Shawn N Reviewed-by: Gwendal Grignou --- board/host/battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/host/battery.c b/board/host/battery.c index e2c4b26b85..9dcde241ab 100644 --- a/board/host/battery.c +++ b/board/host/battery.c @@ -17,7 +17,7 @@ static uint16_t mock_smart_battery[SB_MANUFACTURER_DATA + 1]; int sb_i2c_xfer(int port, int slave_addr, const uint8_t *out, int out_size, uint8_t *in, int in_size, int flags) { - if (out_size == 0 && in_size == 0) + if (out_size == 0) return EC_SUCCESS; if (port != I2C_PORT_BATTERY || slave_addr != BATTERY_ADDR)