diff --git a/firmware/ec/inc/subsystem/rffe/rffe_powermonitor.h b/firmware/ec/inc/subsystem/rffe/rffe_powermonitor.h index 659ad12071..65e73e7132 100644 --- a/firmware/ec/inc/subsystem/rffe/rffe_powermonitor.h +++ b/firmware/ec/inc/subsystem/rffe/rffe_powermonitor.h @@ -41,7 +41,8 @@ typedef enum { RFFE_HB_F_POWER = 0, RFFE_HB_R_POWER, RFFE_LB_F_POWER, - RFFE_LB_R_POWER + RFFE_LB_R_POWER, + RFFE_INVALID_POWER } eRffePowerDetect; /* diff --git a/firmware/ec/src/devices/eth_sw.c b/firmware/ec/src/devices/eth_sw.c index e54b12d853..bc22ab31d8 100644 --- a/firmware/ec/src/devices/eth_sw.c +++ b/firmware/ec/src/devices/eth_sw.c @@ -531,7 +531,6 @@ ReturnStatus eth_sw_config_tiva_client(void *driver, void *params) { ReturnStatus ret = RETURN_OK; int count = 0; - Eth_cfg *s_eth_cfg = (Eth_cfg *)driver; Eth_TcpClient_Params *s_eth_tcpParams = (Eth_TcpClient_Params *)params; Task_Handle taskHandle_client; diff --git a/firmware/ec/src/devices/ocmp_wrappers/ocmp_fe.c b/firmware/ec/src/devices/ocmp_wrappers/ocmp_fe.c index 50d0cc9dbc..ffa080b632 100644 --- a/firmware/ec/src/devices/ocmp_wrappers/ocmp_fe.c +++ b/firmware/ec/src/devices/ocmp_wrappers/ocmp_fe.c @@ -79,7 +79,6 @@ bool static _set_config(void *driver, unsigned int param_id, void *return_buf) rffeBand *band = (rffeBand *)return_buf; switch (param_id) { case FE_CFG_BAND: { - rffeChannel *cfg = driver; ret = rffe_ctrl_set_band(driverCfg->channel, *band); break; } diff --git a/firmware/ec/src/post/post.c b/firmware/ec/src/post/post.c index 7cd03cfae2..6181922f0d 100644 --- a/firmware/ec/src/post/post.c +++ b/firmware/ec/src/post/post.c @@ -70,7 +70,7 @@ static OCMPMessageFrame *post_create_execute_msg(OCMPSubsystem OC_subSystem); static void post_activate(OCMPMessageFrame *pPOSTMsg); static void post_process_rx_msg(OCMPMessageFrame *pPOSTMsg); static void post_move_to_next_subsystem(); -static void post_update_result_to_bigbrother(OCMPMessageFrame *pPOSTMsg); +/* static void post_update_result_to_bigbrother(OCMPMessageFrame *pPOSTMsg); */ /***************************************************************************** ** FUNCTION NAME : _post_complete diff --git a/firmware/ec/src/post/post_util.c b/firmware/ec/src/post/post_util.c index 6e13222f35..c3cd372e7b 100644 --- a/firmware/ec/src/post/post_util.c +++ b/firmware/ec/src/post/post_util.c @@ -12,6 +12,7 @@ #include "inc/common/system_states.h" #include "platform/oc-sdr/schema/schema.h" #include "src/registry/SSRegistry.h" +#include extern const Component sys_schema[OC_SS_MAX_LIMIT]; extern OCSubsystem *ss_reg[SUBSYSTEM_COUNT]; @@ -52,6 +53,12 @@ void post_update_POSTData(POSTData *pData, uint8_t I2CBus, uint8_t devAddress, pData->devId = devId; } #else + +extern void post_update_POSTStatus(POSTData *pData, ePostCode status); +extern void post_init_POSTData(POSTData *pData, OCMPSubsystem subsystem, + uint8_t devSno); +void post_update_POSTresult(POSTData *postData); + static uint8_t deviceCount = 0; /* Execute POST for a given device driver (performs deep copy of alert_data) */ @@ -93,6 +100,8 @@ static ePostCode _postDriver(const Component *subsystem, const Component *dev, "failed."); } } + + return postcode; } ReturnStatus _execPost(OCMPMessageFrame *pMsg, unsigned int subsystem_id) @@ -118,7 +127,6 @@ ReturnStatus _execPost(OCMPMessageFrame *pMsg, unsigned int subsystem_id) } } POSTData postData; - ePostCode postcode = POST_DEV_MISSING; uint8_t devSno = 0; const Component *comp = &subsystem->components[0]; for (uint8_t comp_id = 0; (comp && comp->name); @@ -198,7 +206,6 @@ ReturnStatus _execPost(OCMPMessageFrame *pMsg, unsigned int subsystem_id) void post_update_POSTresult(POSTData *postData) { /* Write a device info to flash but use a dummy function for REV B boards.*/ - uint8_t iter = 0; /* Dump structure at particular location*/ if ((postData->subsystem == OC_SS_SYS) && (postData->devSno == 1)) { deviceCount = 0; diff --git a/firmware/ec/src/registry/SSRegistry.c b/firmware/ec/src/registry/SSRegistry.c index 80d4964be4..8237ea6485 100644 --- a/firmware/ec/src/registry/SSRegistry.c +++ b/firmware/ec/src/registry/SSRegistry.c @@ -272,8 +272,6 @@ static bool _handleMsgTypePOST(OCMPMessageFrame *pMsg, const Component *comp, unsigned int subsystem_id) { /* Determine driver & parameter */ - unsigned int param_id = 0; - uint8_t *buf_ptr = pMsg->message.ocmp_data; bool dev_handled = false; switch (pMsg->message.action) { case OCMP_ACTION_TYPE_SET: diff --git a/firmware/ec/src/subsystem/rffe/rffe_powermonitor.c b/firmware/ec/src/subsystem/rffe/rffe_powermonitor.c index f1f31c4278..3a1895967b 100644 --- a/firmware/ec/src/subsystem/rffe/rffe_powermonitor.c +++ b/firmware/ec/src/subsystem/rffe/rffe_powermonitor.c @@ -119,6 +119,8 @@ ReturnStatus rffe_powermonitor_read_power(const I2C_Dev *i2c_dev, } else if (rfPowerSelect == RFFE_STAT_REV_POWER) { rfPowerDetect = RFFE_LB_R_POWER; } + } else { + rfPowerDetect = RFFE_INVALID_POWER; } /* Bit 7 - Single-Ended/Differential Inputs(SD)