Fix signing script: Add missing quotes around string test.

Change-Id: I01c5da48b6fdb48ae45cdb21a6ca7484ad6b09dc

Review URL: http://codereview.chromium.org/3106027
This commit is contained in:
Gaurav Shah
2010-08-20 12:28:51 -07:00
parent 8c762cb2cf
commit 33c44fc14f

View File

@@ -52,6 +52,7 @@ OUTPUT_IMAGE=$4
# Re-calculate rootfs hash, update rootfs and kernel command line. # Re-calculate rootfs hash, update rootfs and kernel command line.
# Args: IMAGE KEYBLOCK PRIVATEKEY # Args: IMAGE KEYBLOCK PRIVATEKEY
recalculate_rootfs_hash() { recalculate_rootfs_hash() {
echo "Recalculating rootfs"
local image=$1 # Input image. local image=$1 # Input image.
local keyblock=$2 # Keyblock for re-generating signed kernel partition local keyblock=$2 # Keyblock for re-generating signed kernel partition
local signprivate=$3 # Private key to use for signing. local signprivate=$3 # Private key to use for signing.
@@ -69,7 +70,7 @@ recalculate_rootfs_hash() {
# sha1 63b7ad16cb9db4b70b28593f825aa6b7825fdcf2" # sha1 63b7ad16cb9db4b70b28593f825aa6b7825fdcf2"
# #
if [ -z ${dm_config} ]; then if [ -z "${dm_config}" ]; then
echo "WARNING: Couldn't grab dm_config. Aborting rootfs hash calculation" echo "WARNING: Couldn't grab dm_config. Aborting rootfs hash calculation"
return return
fi fi
@@ -120,8 +121,7 @@ get_firmwarebin_from_shellball() {
local input=$1 local input=$1
local output_dir=$2 local output_dir=$2
uudecode -o - ${input} | tar -C ${output_dir} -zxf - 2>/dev/null || \ uudecode -o - ${input} | tar -C ${output_dir} -zxf - 2>/dev/null || \
echo "Extracting firmware autoupdate failed. echo "Extracting firmware autoupdate failed." && exit 1
Try re-running with FW_NOUPDATE=1." && exit 1
} }
# Re-sign the firmware AU payload inside the image rootfs with a new keys. # Re-sign the firmware AU payload inside the image rootfs with a new keys.
@@ -213,7 +213,7 @@ sign_for_factory_install() {
# Firmware payload signing hidden behind a flag until it actually makes # Firmware payload signing hidden behind a flag until it actually makes
# it into the image. # it into the image.
if [ ! "${FW_UPDATE}" == "1" ]; then if [ "${FW_UPDATE}" == "1" ]; then
resign_firmware_payload ${INPUT_IMAGE} resign_firmware_payload ${INPUT_IMAGE}
fi fi