From 3725b32aa560d4ace83579faf629286b8cb88b9c Mon Sep 17 00:00:00 2001 From: Anton Staaf Date: Tue, 9 Dec 2014 09:12:37 -0800 Subject: [PATCH] Ryu: Add dynamic USB pullup support Ryu Proto 3 has a FET to control the D+ USB pullup. This change enables control of that FET using the board specific USB connect and disconnect functions. Signed-off-by: Anton Staaf BRANCH=None BUG=None TEST=make buildall -j Change-Id: I60cd4d36c19f235800980edc53003490589627c7 Reviewed-on: https://chromium-review.googlesource.com/234395 Trybot-Ready: Anton Staaf Tested-by: Anton Staaf Reviewed-by: Vic Yang Commit-Queue: Anton Staaf --- board/ryu/board.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/board/ryu/board.c b/board/ryu/board.c index fef69fe46a..7d6bf76042 100644 --- a/board/ryu/board.c +++ b/board/ryu/board.c @@ -187,14 +187,10 @@ void ccd_board_disconnect(void) void usb_board_connect(void) { - /* - * TODO(robotboy): Enable DP pullup for Proto 3, Proto 2 doesn't have - * the DP pullup, so case closed debug will only work on a Proto 2 if - * the board is reworked, and this function is updated. - */ + gpio_set_level(GPIO_USB_PU_EN_L, 0); } void usb_board_disconnect(void) { - /* TODO(robotboy): Disable DP pullup for Proto 3 */ + gpio_set_level(GPIO_USB_PU_EN_L, 1); }