From 4cd2b6c011a7337dcdc3686336e2e1ce24ca419a Mon Sep 17 00:00:00 2001 From: Chiranjeevi Rapolu Date: Tue, 30 Jun 2015 14:04:47 -0700 Subject: [PATCH] Fix stack overflow exception in host-command task. Increase host-command task stack size by 128 to avoid stack overflow exception. BRANCH=None BUG=chrome-os-partner:42071 TEST=Test for general functionality and confirm that no stack overflow happens. Change-Id: I5513dbca84cf556357c25cddbcde00e0db6d271b Signed-off-by: Chiranjeevi Rapolu Reviewed-on: https://chromium-review.googlesource.com/282810 Reviewed-by: Shawn N Commit-Queue: Divya Jyothi --- board/cyan/ec.tasklist | 2 +- chip/mec1322/config_chip.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/board/cyan/ec.tasklist b/board/cyan/ec.tasklist index 3df59e4321..8e88552f8e 100644 --- a/board/cyan/ec.tasklist +++ b/board/cyan/ec.tasklist @@ -22,7 +22,7 @@ TASK_NOTEST(MOTIONSENSE, motion_sense_task, NULL, LARGER_TASK_STACK_SIZE) \ TASK_NOTEST(CHIPSET, chipset_task, NULL, TASK_STACK_SIZE) \ TASK_NOTEST(KEYPROTO, keyboard_protocol_task, NULL, TASK_STACK_SIZE) \ - TASK_ALWAYS(HOSTCMD, host_command_task, NULL, TASK_STACK_SIZE) \ + TASK_ALWAYS(HOSTCMD, host_command_task, NULL, HOST_CMD_TASK_STACK_SIZE) \ TASK_ALWAYS(CONSOLE, console_task, NULL, CONSOLE_TASK_STACK_SIZE) \ TASK_NOTEST(PORT80, port80_task, NULL, TASK_STACK_SIZE) \ TASK_ALWAYS(POWERBTN, power_button_task, NULL, TASK_STACK_SIZE) \ diff --git a/chip/mec1322/config_chip.h b/chip/mec1322/config_chip.h index 8257b03d32..31e85ec3e4 100644 --- a/chip/mec1322/config_chip.h +++ b/chip/mec1322/config_chip.h @@ -76,6 +76,7 @@ #define CHARGER_TASK_STACK_SIZE 640 #define HOOKS_TASK_STACK_SIZE 640 #define CONSOLE_TASK_STACK_SIZE 640 +#define HOST_CMD_TASK_STACK_SIZE 640 /* Default task stack size */ #define TASK_STACK_SIZE 512