From 4d4facda912767215d485bc83ddfa7ef9c060c2e Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Thu, 20 Jun 2013 08:24:25 -0500 Subject: [PATCH] falco: peppy: slippy: mark LPC_CLKRUN_L as open drain The LPC_CLKRUN_L signal on these boards has an external pull up to the correct PCH rail. Therefore, configure the pin controlling LPC_CLKRUN_L as open drain. BUG=chrome-os-partner:19811 BUG=chrome-os-partner:20331 BRANCH=None TEST=Built and flashed. Interrogated GPIOODR register for port M: > rw 0x4006350c read 0x4006350c = 0x00000004 Change-Id: I50dc90d784bd1d1f318b401e5d7d6e06bf0f1e47 Signed-off-by: Aaron Durbin Reviewed-on: https://gerrit.chromium.org/gerrit/59416 Reviewed-by: Duncan Laurie Reviewed-by: Sameer Nanda --- board/falco/board.c | 2 +- board/peppy/board.c | 2 +- board/slippy/board.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/board/falco/board.c b/board/falco/board.c index 40b983ce2f..e516c93b99 100644 --- a/board/falco/board.c +++ b/board/falco/board.c @@ -106,7 +106,7 @@ const struct gpio_info gpio_list[GPIO_COUNT] = { {"TOUCHSCREEN_RESET_L", LM4_GPIO_N, (1<<7), GPIO_OUT_LOW, NULL}, {"EC_EDP_VDD_EN", LM4_GPIO_J, (1<<5), GPIO_OUT_LOW, NULL}, - {"LPC_CLKRUN_L", LM4_GPIO_M, (1<<2), GPIO_OUT_HIGH, NULL}, + {"LPC_CLKRUN_L", LM4_GPIO_M, (1<<2), GPIO_ODR_HIGH, NULL}, {"USB1_ENABLE", LM4_GPIO_E, (1<<4), GPIO_OUT_LOW, NULL}, {"USB2_ENABLE", LM4_GPIO_D, (1<<5), GPIO_OUT_LOW, NULL}, diff --git a/board/peppy/board.c b/board/peppy/board.c index d03a632c70..160ebef21b 100644 --- a/board/peppy/board.c +++ b/board/peppy/board.c @@ -106,7 +106,7 @@ const struct gpio_info gpio_list[GPIO_COUNT] = { {"TOUCHSCREEN_RESET_L", LM4_GPIO_N, (1<<7), GPIO_OUT_LOW, NULL}, {"EC_EDP_VDD_EN", LM4_GPIO_J, (1<<5), GPIO_OUT_LOW, NULL}, - {"LPC_CLKRUN_L", LM4_GPIO_M, (1<<2), GPIO_OUT_HIGH, NULL}, + {"LPC_CLKRUN_L", LM4_GPIO_M, (1<<2), GPIO_ODR_HIGH, NULL}, {"USB1_ENABLE", LM4_GPIO_E, (1<<4), GPIO_OUT_LOW, NULL}, {"USB2_ENABLE", LM4_GPIO_D, (1<<5), GPIO_OUT_LOW, NULL}, diff --git a/board/slippy/board.c b/board/slippy/board.c index d3d40ed056..c17f373c69 100644 --- a/board/slippy/board.c +++ b/board/slippy/board.c @@ -106,7 +106,7 @@ const struct gpio_info gpio_list[GPIO_COUNT] = { {"TOUCHSCREEN_RESET_L", LM4_GPIO_N, (1<<7), GPIO_OUT_LOW, NULL}, {"EC_EDP_VDD_EN", LM4_GPIO_J, (1<<5), GPIO_OUT_LOW, NULL}, - {"LPC_CLKRUN_L", LM4_GPIO_M, (1<<2), GPIO_OUT_HIGH, NULL}, + {"LPC_CLKRUN_L", LM4_GPIO_M, (1<<2), GPIO_ODR_HIGH, NULL}, {"USB1_ENABLE", LM4_GPIO_E, (1<<4), GPIO_OUT_LOW, NULL}, {"USB2_ENABLE", LM4_GPIO_D, (1<<5), GPIO_OUT_LOW, NULL},