From 5307725091ccb54cb5e849fedbfc26388f13023f Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Sun, 22 Jan 2017 17:07:33 -0800 Subject: [PATCH] eve: Fix hibernate GPIO states - Lid switch has an external pull-down so we should not enable one here in hibernate - LEDs should be high to turn off BUG=chrome-os-partner:58666 BRANCH=none TEST=manual testing: 1) power off and enter hibernate with alt+volup+h 2) ensure LEDs turn off 3) ensure system stays off when lid is closed 4) ensure system powers up when lid is opened Change-Id: I3a13fa6e0fbcad4925f9fb1d96e6c38d7bb453c8 Signed-off-by: Duncan Laurie Reviewed-on: https://chromium-review.googlesource.com/431137 Reviewed-by: Aaron Durbin --- board/eve/board.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/board/eve/board.c b/board/eve/board.c index acce082513..9a6f713486 100644 --- a/board/eve/board.c +++ b/board/eve/board.c @@ -561,14 +561,14 @@ void board_hibernate_late(void) { int i; const uint32_t hibernate_pins[][2] = { - {GPIO_LID_OPEN, GPIO_INT_RISING | GPIO_PULL_DOWN}, + {GPIO_LID_OPEN, GPIO_INT_RISING}, /* Turn off LEDs in hibernate */ - {GPIO_CHARGE_LED_1, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_2, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_3, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_4, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_5, GPIO_OUTPUT | GPIO_LOW}, - {GPIO_CHARGE_LED_6, GPIO_OUTPUT | GPIO_LOW}, + {GPIO_CHARGE_LED_1, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_2, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_3, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_4, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_5, GPIO_OUTPUT | GPIO_HIGH}, + {GPIO_CHARGE_LED_6, GPIO_OUTPUT | GPIO_HIGH}, /* * BD99956 handles charge input automatically. We'll disable * charge output in hibernate. Charger will assert ACOK_OD