From 5d76ffc62d89eb3f867aec3dc27c6ed2cbfcc172 Mon Sep 17 00:00:00 2001 From: Alec Berg Date: Fri, 17 Oct 2014 15:45:19 -0700 Subject: [PATCH] pd: add data role to pd message header Added data role bit to PD message header. The data role is currently tied to power role: source = DFP, sink = UFP. BUG=none BRANCH=samus TEST=tested with third part protocol analyzer Change-Id: Ic56ea92899d20013aace108cee794d10c3780364 Signed-off-by: Alec Berg Reviewed-on: https://chromium-review.googlesource.com/224178 Reviewed-by: Vincent Palatin --- include/usb_pd.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/usb_pd.h b/include/usb_pd.h index 82fdaec122..48acbb0f6c 100644 --- a/include/usb_pd.h +++ b/include/usb_pd.h @@ -491,9 +491,11 @@ enum pd_data_msg_type { #define PD_ROLE_SOURCE 1 /* build message header */ +/* TODO(crosbug.com/p/28343): need to seperate data role from power role */ #define PD_HEADER(type, role, id, cnt) \ ((type) | (PD_REV20 << 6) | \ - ((role) << 8) | ((id) << 9) | ((cnt) << 12) | \ + ((role) << 5) | ((role) << 8) | \ + ((id) << 9) | ((cnt) << 12) | \ PD_BMC_SUPPORTED) #define PD_HEADER_CNT(header) (((header) >> 12) & 7)