From 5d8a4ba6f252fbda1111c25a05523c73ebe3343d Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Wed, 4 Apr 2018 09:18:39 -0600 Subject: [PATCH] config.h: clarify CONFIG_INTERNAL_STORAGE semantics The semantics in the EC code base are that CONFIG_INTERNAL_STORAGE implies eXecute-In-Place semantics (XIP). Add a comment to make that abundantly clear. BUG=none BRANCH=none TEST=none Change-Id: I80152eeb41dd35716f4c09ffd1753ae128aa7d2d Signed-off-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/995956 Reviewed-by: Vincent Palatin --- include/config.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/config.h b/include/config.h index 9043f3482f..98e28b7078 100644 --- a/include/config.h +++ b/include/config.h @@ -1235,7 +1235,9 @@ /* * EC code can reside on internal or external storage. Only one of these - * CONFIGs should be defined. + * CONFIGs should be defined. CONFIG_INTERNAL_STORAGE implies XIP + * (eXecute-In-Place) semantics. i.e. code is being fetched directly from + * storage media. */ #undef CONFIG_EXTERNAL_STORAGE #undef CONFIG_INTERNAL_STORAGE