From 6e18f8f9813ed873a496cf49ab39dd9b41adc1bc Mon Sep 17 00:00:00 2001 From: Mary Ruthven Date: Thu, 22 Mar 2018 13:37:53 -0700 Subject: [PATCH] rma_reset: fix ignored return value error The fread return value was ignored in rma_reset.c. This caused clang compilation to fail. This change checks the return value. BUG=b:76105747 BRANCH=none TEST=clang compilation no longer fails Change-Id: I710b367008b2e17a94c875ea3eae92bcc75546b0 Signed-off-by: Mary Ruthven Reviewed-on: https://chromium-review.googlesource.com/976555 Commit-Ready: Mary Ruthven Tested-by: Mary Ruthven Reviewed-by: Vadim Bendebury --- extra/rma_reset/rma_reset.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/extra/rma_reset/rma_reset.c b/extra/rma_reset/rma_reset.c index 30a2e652cb..31b88b0bb2 100644 --- a/extra/rma_reset/rma_reset.c +++ b/extra/rma_reset/rma_reset.c @@ -452,6 +452,7 @@ int main(int argc, char **argv) if (a_flag) { FILE *acode; char verify_authcode[RMA_AUTHCODE_BUF_SIZE]; + int rv; acode = fopen("/tmp/authcode", "r"); if (acode == NULL) { @@ -459,7 +460,11 @@ int main(int argc, char **argv) return 1; } - fread(verify_authcode, 1, RMA_AUTHCODE_BUF_SIZE, acode); + rv = fread(verify_authcode, 1, RMA_AUTHCODE_BUF_SIZE, acode); + if (rv != RMA_AUTHCODE_BUF_SIZE) { + printf("Error reading saved authcode\n"); + return 1; + } if (strcmp(verify_authcode, authcode) == 0) printf("Code Accepted\n"); else